[HOLD for payment 2023-05-29] Members in #announce are not sorted alphabetically as it is on manage member page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any workspace #announce report
3. Click on #announce in the top
4. Click on members and observe that members are not arranged alphabetically
5. Open settings
6. Open workspaces
7. Open the workspace which was observed in upper steps
8. Open manage member
9. Observe that members are arranged alphabetically

Expected Result:

App should arrange members in #announce alphabetically as it does for same workspace in manage members

Actual Result:

App does not arrange members in #announce alphabetically

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.89-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.46.mp4

alphabetically.not.arranged.issue.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679731871858339
View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

Yup - I'm able to replicate this too

Announce:

Workspace:

[MelvinBot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sophiepintoraetz]

Hey @youssef-lr - do you mind taking a look at this.

[youssef-lr]

Hey @sophiepintoraetz, I'll work on this!

[sophiepintoraetz]

Anything here, @youssef-lr? 🙏

[youssef-lr]

I got this fixed in my dev environment, it's pretty straightforward to sort participants, however I'll need to test on a high traffic account to see if the sorting can affect performance.

[MelvinBot]

@youssef-lr @sophiepintoraetz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@youssef-lr, @sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@youssef-lr, @sophiepintoraetz Eep! 4 days overdue now. Issues have feelings too...

[youssef-lr]

Creating a PR shortly for this.

[sophiepintoraetz]

@youssef-lr - please can we action this?

[youssef-lr]

Just created a PR @sophiepintoraetz . I need to fix an iOS and Android issue for screenshots purposes, but otherwise the code is ready.

[sophiepintoraetz]

Hey youssef - did you need help with the screenshots?

[youssef-lr]

Getting to this today @sophiepintoraetz, I've been swamped with issues assigned to me the past few days.

[sophiepintoraetz]

@youssef-lr bumping, please 🙏 (I'm going to take the reviewing label off until the PR is actually ready for review to help us keep focus on this)

[youssef-lr]

Finally got around to getting my mobile dev env working again. Sorry for the delay!

[melvin-bot]

@youssef-lr, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sophiepintoraetz]

Hey @youssef-lr - what's needed here to finish this off?

[youssef-lr]

Hey @sophiepintoraetz - I was fully focusing on EC3/Tasks issues due to the tight deadline. I'm able to get to this today, there's a couple changes that came up during the review which I'll implement today.

[youssef-lr]

PR updated.

[melvin-bot]

@youssef-lr, @sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!

[youssef-lr]

PR merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Sort participants in report participants and workspace invite page #17421

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@youssef-lr] Determine if we should create a regression test for this bug.
• [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dhanashree-sawant]

Hi @sophiepintoraetz, reporting bonus was left for this issue, can you have a look once?