[HOLD for payment 2023-06-07] [$1000] Personal details - DOB field does not get updated if year only changed.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #16474

Action Performed:

1. Open settings > profile > personal details > date of birth > date of birth input
2. Press year to select the new year from the list
3. Tap on Save

Expected Result:

DOB should be updated of the year was changed.

Actual Result:

DOB field does not get updated if year only changed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.89.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5992434_year_3.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0124a630171dea7ddd
• Upwork Job ID: 1642120128439169024
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

Reproduced. Adding Eng.

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

Hey @roryabraham can you take a peek at these two related jobs to see if they can be combined into this one? If they can be combined, I think we can still pay the reporter for finding these, correct?

#16529
#16518

[lschurr]

@roryabraham - thoughts on this one?

[bernhardoj]

Just sharing my opinion specifically on this issue (not the other 2). I think it makes sense that the DOB field is not updated if we only change the year/month. We can't guarantee the currently selected day are available in the newly selected year/month. For example, the currently selected date is Feb 29, 2000, then the user changes the year to 2001. However, 29th February does not exist in 2001, so we can't update the date to Feb 29, 2001. Thus, we must select the full date (day, month, year). Maybe some users found the UI is not intuitive, and to solve that, we could add an OK/Cancel button to confirm the date selection.

[roryabraham]

@Christinadobrzyn @lschurr I think this looks related but different to those other two issues.

I see what @bernhardoj is saying but disagree on this point:

We can't guarantee the currently selected day are available in the newly selected year/month

Because we can check this quite easily.

So I think we should update the Expected Results:

Action Performed: Change just the year in your birth date setting.

Expected result: When fields in the date picker are changed, validate that the new date is valid. If it is not, disable the Save button and display a red error above the button saying something to the effect of "Please enter a valid date"

[bernhardoj]

Yes, we need to check it. What I mean by "guarantee" is setting the new date as it is 😅. For the expected result, I think it's better to select the last available day if it's invalid. This is the behavior with native web date picker.

Screen.Recording.2023-04-01.at.00.10.53.mov

[lschurr]

@roryabraham should we add the Internal or External label and work toward fixing this?

[roryabraham]

Let's get aligned on the expected behavior in slack first. Then this can be External.

[roryabraham]

Okay, we've got a majority consensus in slack on the expected behavior here:

Action Performed: Change just the year in your birth date setting.

Expected result: When fields in the date picker are changed, validate that the new date is valid. If it is not, disable the Save button and display a red error above the button saying something to the effect of "Please enter a valid date"

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0124a630171dea7ddd

[MelvinBot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Current assignee @roryabraham is eligible for the External assigner, not assigning anyone new.

[lschurr]

Taking this back from you @greg-schroeder - thanks!

How we doing on this one @roryabraham?

[Santhosh-Sellavel]

Seems @roryabraham is OOO.

@lschurr Can we wait or assign another CME here?

Or @mountiny If you have time for this can you pick this up, Assuming you already know the context here

[melvin-bot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lschurr]

Hey @alex-mechler - it looks like @roryabraham is OOO. Are you able to pick this one up for us?

[mountiny]

Seeing the ping just now, I can help as I have worked on the component before! Sorry for the ping Alex!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Personal details - DOB field updating once year or month has been changed #18577

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Had to recreate the job since it closed. @Santhosh-Sellavel and @burczu, could you apply to the job in Upwork? https://www.upwork.com/jobs/~01be498948453fb051

[lschurr]

Also @Santhosh-Sellavel - do we need a regression test for this one?

[lschurr]

Hi @Santhosh-Sellavel and @burczu - could you please apply for the job in Upwork so this can be closed out? https://www.upwork.com/jobs/~01be498948453fb051

[Santhosh-Sellavel]

@lschurr Only C+ is due here. I applied for the job. @burczu is from Callstack Team.

[lschurr]

Ah, great thanks!

[lschurr]

Paid and closed.