[HOLD for payment 2023-04-04] Workspace -Unable to add Chase bank account, can't choose a bank account ending in 1111/0000

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Workspaces -> Open any WS -> Connect bank account -> Connect online with Plaid
4. On the bank account list select "Chase"
5. Enter the credentials "user_good / pass_good" in "First Platypus Bank"
6. Select mobile and enter "credentials_good" as the verification mode
7. Checkmark the "Plaid Checking" and "Plaid Saving"
8. Checkmark the 2 options under "additional information you want to share" -> Click on continue
9. Click "Connect account information"
10. Click on the last confirmation on the plaid modal
11. Select the bank account ending in 1111

Expected Result:

Unable to add Chase bank account, can't choose a bank account ending in 1111/0000

Actual Result:

The bank account ending in 1111 was selected and Chase bank account added successfully

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.90.6

Reproducible in staging?: Yes

Reproducible in production?: Unable to verify

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5995087_Recording__4041.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Everybody was OOO, so I assigned 10 random eligible people.

[kbecciv]

Putting Deploy Deploy blocker label because QA team is unable to verify this issue in Production, it worked on last Regression on Saturday.

[fedirjh]

This is a regression from 204ded3

Explanation

In AddPlaidBankAccount we save the selectedPlaidAccountID in reimbursementAccountDraft an then we use it to select the account from the list , However the changes made in #15772 caused getDefaultStateForField to no longer rely on draftValues. So the selectedPlaidAccountID fallback to '' making it impossible to highlight the selected account.

App/src/pages/ReimbursementAccount/BankAccountPlaidStep.js

Lines 92 to 94 in 0763be5

	onSelect={(plaidAccountID) => {
	ReimbursementAccount.updateReimbursementAccountDraft({plaidAccountID});
	}}

Solution

To address this issue, we can retrieve the draft value directly from the AddPlaidBankAccount component by replacing the following line:

App/src/pages/ReimbursementAccount/BankAccountPlaidStep.js

Line 68 in 0763be5

const selectedPlaidAccountID = this.props.getDefaultStateForField('plaidAccountID', '');

With

const selectedPlaidAccountID = lodashGet(this.props.reimbursementAccountDraft, 'plaidAccountID', '');

[mollfpr]

Thanks @fedirjh!

@tienifr Could you also check if any others form that impact by removing reimbursementAccountDraft from getDefaultStateForField function?

[tienifr]

Thank @fedirjh @mollfpr The problem is because of Picker. Why other places that use reimbursementAccountDraft work well? Because the TextInput, CheckboxWithLabel, ... has defaultValue and shouldSaveDraft, so in Form.js we have the logic to update the value base on defaultValue or draftValue. But in https://github.com/Expensify/App/blob/0763be562293a1b9e3782eaeee0843a7f805e38d/src/components/Picker/Picker.js we don't use shouldSaveDraft and defaultValue. Please correct me if I'm wrong.
I have some problem when perform this issue on dev. Do you know how to do it?

[joelbettner]

Unassigning myself from this as I got assigned another hourly at the same time.

[luacmartins]

@tienifr what issues are you seeing on dev?

[luacmartins]

@fedirjh that solution doesn't seem to be enough. I see the following error when selecting the account and submitting it:

[MariaHCD]

Looks like this was caused because of the change to getDefaultStateForField in this PR: https://github.com/Expensify/App/pull/15772/files#diff-151644ad98569c9b8b94994ae6549398c346616bcae7dc25d98a46d3f532b41eL128

[luacmartins]

Fix is being deployed to staging. Closing this issue. Thanks everyone!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.90-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Get PlaidData values #16607

If no regressions arise, payment will be issued on 2023-04-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty