[HOLD for payment 2023-04-20] Incorrect Icon for "Copy" Action

[fukawi2]

The current UI in newDot uses an icon that is traditionally used for "Paste" actions, instead of a traditionally "copy" style icon.

Current icon, a clipboard style graphic:

Example of traditional cut/copy/paste icons, with a duplicates sheet of paper to represent "copy" action:

This is super confusing to anyone that has a mental subconscious bias to expect the traditional icon when looking for the 'copy' option.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.89-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Slack conversation: https://expensify.slack.com/archives/C03TME82F/p1680109421560969

[MelvinBot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[slafortune]

@shawnborton - should this get the external lable?

[shawnborton]

Not yet - I need to create the icon first and then we can add external. Will keep you posted!

[MelvinBot]

@shawnborton, @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

[shawnborton]

No update

[shawnborton]

Here is an updated icon:

And here is as an .svg which we need for the app: copy.svg.zip

This is such a small change that I'm not sure if it's worth making it external. @fukawi2 any interest in updating this yourself? Otherwise maybe we can see if an another engineer wants to grab it before going external.

[fukawi2]

I love it. Updating it is way outside my wheelhouse. I'll post it to #engineering-chat though and see if someone more familiar with App can spare a few mins to do it.

[NikkiWines]

I can grab this and update it today 🤚

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Clipboard icon to Copy icon #17008

If no regressions arise, payment will be issued on 2023-04-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: Not a bug so N/A
• [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not a bug so N/A
• [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not a bug so N/A
• [@slafortune] Determine if we should create a regression test for this bug.
• [@NikkiWines] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

PR done within 3 business days - paid aimane $1500 #17008