Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD][$1000] Gap between edit message and keyboard on mWeb chrome #16718

Closed
1 of 6 tasks
kavimuru opened this issue Mar 29, 2023 · 62 comments
Closed
1 of 6 tasks

[HOLD][$1000] Gap between edit message and keyboard on mWeb chrome #16718

kavimuru opened this issue Mar 29, 2023 · 62 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Mar 29, 2023

Held on #30912
Held on #33725

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in android chrome
  2. Open any report
  3. Edit any message

Expected Result:

There should be no gap between keyboard and edit message like there isn't any gap in android app

Actual Result:

There is large gap between edit message and keyboard on mWeb chrome

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.91-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

gap.android.chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680022112433229

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ea8064e577f077b
  • Upwork Job ID: 1646253435450802176
  • Last Price Increase: 2023-04-12
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 29, 2023
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@MelvinBot
Copy link

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

@adelekennedy 10 days overdue. I'm getting more depressed than Marvin.

1 similar comment
@MelvinBot
Copy link

@adelekennedy 10 days overdue. I'm getting more depressed than Marvin.

@adelekennedy adelekennedy added the Needs Reproduction Reproducible steps needed label Apr 11, 2023
@adelekennedy
Copy link

@kavimuru I'm not able to reproduce this 😬 can you give it a try and let me know if you're seeing the gap?

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@kavimuru
Copy link
Author

I tagged @dhanashree-sawant in the slack

@dhanashree-sawant
Copy link

Hi @adelekennedy, I am still able to recreate on latest staging.

Untitled.mp4

@MelvinBot
Copy link

@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@adelekennedy adelekennedy added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Apr 12, 2023
@melvin-bot melvin-bot bot changed the title Gap between edit message and keyboard on mWeb chrome [$1000] Gap between edit message and keyboard on mWeb chrome Apr 12, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~016ea8064e577f077b

@MelvinBot
Copy link

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 12, 2023
@MelvinBot
Copy link

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the Overdue label Apr 14, 2023
@eVoloshchak

This comment was marked as duplicate.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 14, 2023
@cristipaval
Copy link
Contributor

@koko57 Great, thanks for taking care of this one. Hold is removed now.

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@cristipaval
Copy link
Contributor

@koko57 what's the status on this one?

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@koko57
Copy link
Contributor

koko57 commented Nov 20, 2023

@cristipaval Sorry, I didn't notice that you removed on hold! BaseInvertedFlatList is still not migrated to FlashList yet - I think we should wait for it to be migrated first.

@koko57
Copy link
Contributor

koko57 commented Nov 21, 2023

@cristipaval I aksed my colleague that is working on the migration - there's no ticket yet for migrating the chat list to Flashlist, but it's planned. Let's put it on HOLD once again.

@cristipaval
Copy link
Contributor

Alright, I'll do it. Do we have a tracking issue for the migration on which we held this one?

@koko57
Copy link
Contributor

koko57 commented Nov 21, 2023

Unfortunately I couldn't find one - these two were closed #28902 #28178. Some of the migrations that are currently being worked on are under the performance project like this one: #30912

@cristipaval
Copy link
Contributor

I see. I think we're good if we held this one on #30912

@cristipaval cristipaval changed the title [$1000] Gap between edit message and keyboard on mWeb chrome [HOLD][$1000] Gap between edit message and keyboard on mWeb chrome Nov 21, 2023
@cristipaval
Copy link
Contributor

Thank you @koko57!

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
@cristipaval cristipaval changed the title [HOLD][$1000] Gap between edit message and keyboard on mWeb chrome [$1000] Gap between edit message and keyboard on mWeb chrome Jan 2, 2024
@cristipaval cristipaval added Daily KSv2 and removed Monthly KSv2 labels Jan 2, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@cristipaval
Copy link
Contributor

Removing the HOLD. @koko57, do you have some spare time to investigate this one again? 🙏

@koko57
Copy link
Contributor

koko57 commented Jan 2, 2024

@cristipaval We were holding for some other issue, because the ticket for the main chat wasn't created back then 🙂 It was created recently, so now we need to hold on this one (#33725).

But if I have some spare time I'll see what's the current status of the issue - if anything changed in the meantime

@cristipaval cristipaval added Monthly KSv2 and removed Daily KSv2 labels Jan 2, 2024
@cristipaval cristipaval changed the title [$1000] Gap between edit message and keyboard on mWeb chrome [HOLD][$1000] Gap between edit message and keyboard on mWeb chrome Jan 2, 2024
@cristipaval
Copy link
Contributor

Thanks @koko57!

@melvin-bot melvin-bot bot added the Overdue label Feb 2, 2024
@cristipaval
Copy link
Contributor

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2024
@cristipaval
Copy link
Contributor

same

@melvin-bot melvin-bot bot removed the Overdue label Mar 6, 2024
@adelekennedy
Copy link

coming from our updated process - I think we should close this issue based on our new standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants