[Hold 12775][$1000] Workspace avatar turn into old avatar after being removed.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any workspace, try to upload new avatar.
2. Try to remove it, click on avatar again to show the choose photo popup, wait for seconds
3. Notice that the Workspace avatar now return to the old one after being removed before that.

Expected Result:

Workspace avatar should stay empty.
#Actual Result:
Workspace avatar now return to the old one after being removed before that.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

OATQ6555.1.MP4

RPReplay_Final1680106192.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680106486925299

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f8050b49fb096d4b
• Upwork Job ID: 1649935446442274816
• Last Price Increase: 2023-04-23

[MelvinBot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

I was unable to reproduce this @kavimuru . Let me know if I am missing something in my approach!

RPReplay_Final1680287665.2.MP4

[kavimuru]

@kevinksullivan hmm, I am not able to reproduce in the version 1.2.94-0

[kevinksullivan]

Going to close out for now then.

[MelvinBot]

@kevinksullivan Be sure to fill out the Contact List!

[hungvu193]

hey @kevinksullivan, I'm still able to reproduce, will send the video shortly

iOS version 1.2.93-0
https://user-images.githubusercontent.com/16502320/229966540-209a96a8-176d-44dc-8b5d-1aa1e56bb93b.MOV

[kevinksullivan]

Hi @hungvu193 we tested on 1.2.94-0 most recently and couldn't reproduce. Can you test on a more up to date version?

[hungvu193]

@kevinksullivan sure, I'll wait for 1.2.96-4 version and let you know the result

[hungvu193]

@kevinksullivan I still can reproduce at latest ios version 1.2.97-2
https://user-images.githubusercontent.com/16502320/230757038-c22bc7af-3078-4916-a9c3-7f35d5599e9a.MOV

[hungvu193]

hey @kevinksullivan, I'm still able to reproduce this with IOS, mWeb Safari most recently on 1.3.0-0

[MelvinBot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

I am OOO this week so reassigning for reproduction. Thanks @sakluger !

[MelvinBot]

@sakluger @kavimuru this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[sakluger]

I was able to reproduce using the MacOS native app on version 1.3.2-5. I also used the Take Photo option. After removing the avatar and clicking to add another, it reverted to the old avatar.

[neil-marcellini]

@hellohublot yes I think #12775 will fix this because we won't be sending any Push updates to the requesting client and will be sending them back in the HTTP responses instead. We can put this on hold, and once the replay effect fix implemented test to see if it's still happening.

[MelvinBot]

@sakluger @amyevans @sobitneupane this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[MelvinBot]

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

[amyevans]

Going to place this on Hold and add it to the "Replay effect" tracking issue.

[sakluger]

Let's switch this to a weekly to put it in line with the Replay effect issue it's on hold for.

[sakluger]

Still on hold for that other issue.

[neil-marcellini]

Fixed!

Screen.Recording.2023-05-16.at.9.19.36.AM.mov

[hungvu193]

@neil-marcellini am I egilible for reporting bonus?

[neil-marcellini]

Oh right sorry. @sakluger would you take care of @hungvu193 please.

[amyevans]

Thanks for testing @neil-marcellini!

[sakluger]

@neil-marcellini just to confirm, this was fixed by a PR for another issue? I'm pretty sure we decided that if another issue was already reported with the same root cause (the therefore the same PR would fix both), then we wouldn't pay for additional bug reports.

Did this bug report help to identify the root cause?

[neil-marcellini]

Yes it was fixed by a PR for the general replay effect tracking issue. This bug report did not help to identify the root cause, it was only another instance of the bug. #12000 was the first issue where we identified the replay effect I believe.

Thanks for clarifying the policy that we don't pay for additional bug reports with the same root cause as another issue! That's why I leave the payment stuff to the payment experts like yourself 😄

There's plenty more bugs to report @hungvu193!

[hungvu193]

No worries. I understand that. Thank you so much for your explaining @neil-marcellini 😄