[HOLD for payment 2023-05-22] [HOLD #14490] [$1000] Crash on IOURequestPage

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go onto a slow network
2. Login to New Expensify
3. While the LHN is still loading and showing the skeleton UI, click on the global create menu
4. Click on Send Money
5. Enter an amount
6. Press Enter

Expected Result:

You should be taken to the next screen to choose recipients. There should be a skeleton UI on that search page.

Actual Result:

The app crashes.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Issue reported by: n/a (@aimane-chnaif reported this in a PR review here when the bug was introduced and considered edgy/out-of-scope)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680147029222199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016871515dc2088e09
• Upwork Job ID: 1643851935839272960
• Last Price Increase: 2023-04-06

[MelvinBot]

@roryabraham the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[lschurr]

Is this all platforms @roryabraham?

[aimane-chnaif]

Is this all platforms @roryabraham?

yes all platforms.
You need to do actions quickly to go to IOURequestPage before loading personal details.
More high traffic and slower network, easier to reproduce.

[lschurr]

I'm not able to reproduce, but maybe I just don't have a slow enough high traffic network to try. Adding Eng for more eyes.

[MelvinBot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

@youssef-lr, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

Hey @youssef-lr - any thoughts on this one?

[youssef-lr]

I was able to reproduce this as well using Slow 3G in dev tools. Going to add External label to this one.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016871515dc2088e09

[MelvinBot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[MelvinBot]

Current assignee @youssef-lr is eligible for the External assigner, not assigning anyone new.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU participants page crash when we open it while the app is still loading.

What is the root cause of that problem?

The error comes from here, specifically the Str.removeSMSDomain because the login is undefined.

App/src/libs/OptionsListUtils.js

Lines 514 to 523 in 78a9b54

	let allPersonalDetailsOptions = _.map(personalDetails, personalDetail => createOption(
	[personalDetail.login],
	personalDetails,
	reportMapForLogins[personalDetail.login],
	reportActions,
	{
	showChatPreviewLine,
	forcePolicyNamePreview,
	},
	));

App/src/libs/OptionsListUtils.js

Lines 106 to 118 in 78a9b54

	_.chain(logins)
	// Somehow it's possible for the logins coming from report.participants to contain undefined values so we use compact to remove them.
	.compact()
	.each((login) => {
	let personalDetail = personalDetails[login];
	if (!personalDetail) {
	personalDetail = {
	login,
	displayName: Str.removeSMSDomain(login),
	avatar: ReportUtils.getDefaultAvatar(login),
	};
	}

If we look at the code, it actually should be fine when we open the page while the app still loading (which means personalDetails is empty). But how can the loop still runs?

When we open the IOU page, it will call a OpenIOUModalPage API which will return a personal detail object with a local currency code which completes first before the OpenApp completes (which the personalDetails list comes from).

This makes we have a personalDetails list with a single item and only a localCurrencyCode property. That is why the loop runs and login is undefined.

What changes do you think we should make in order to solve the problem?

We shouldn't call the OpenIOUModalPage API if we are still loading the initial data, by checking the _.isEmpty(personalDetails).

App/src/libs/actions/PersonalDetails.js

Lines 268 to 270 in 78a9b54

	function openMoneyRequestModalPage() {
	API.read('OpenIOUModalPage');
	}

It is safe to not call it because we will get the localCurrencyCode from OpenApp too.

The Skeleton UI will be handled here #14490

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes on IOURequest page when open immediately after login

What is the root cause of that problem?

When first enter MoneyRequestModal as soon as login success, OpenIOUModalPage api is called and pusher response is saved to Onyx before getting OpenApp api pusher response.
This case, personalDetails data changes from empty json {} to 1 array with {localCurrencyCode: 'USD"} which makes this loop called and finally crash happens on this line:

App/src/libs/OptionsListUtils.js

Line 366 in 78a9b54

result.alternateText = Str.removeSMSDomain(personalDetail.login);

The crash is not constantly reproducible because of 2 reasons:

• Sometimes OpenIOUModalPage pusher is later than OpenApp pusher. This case, personalDetails data is already complete.
• When user open IOUParticipantsRequest page quickly, OpenIOUModalPage pusher event is not received yet and personalDetails is still empty {}.

What changes do you think we should make in order to solve the problem?

refactor IOUParticipantsRequest, IOUParticipantsSplit pages.
current logic: OptionsListUtils.getNewChatOptions is always called in constructor
new logic:

• call getNewChatOptions only when personalDetails has full current user info (I think login existence check is enough)
• call getNewChatOptions both in constructor (when first enter page) and componentDidUpdate (to update list after reports or personalDetails data fully loaded)

NOTE: Even though OpenApp pusher data has localCurrencyCode, I don't recommend to remove OpenIOUModalPage api call because of following reasons:

• refresh user currency when network becomes online from offline or every time when user visits IOURequest page
• OpenIOUModalPage can be used for another purpose in the future, not only to get user currency

What alternative solutions did you explore? (Optional)

This issue can be on hold or closed because of following reasons:

• this issue is part of [HOLD for payment 2023-05-22] [$4000] Not showing any data on search page when press Cmd+K shortcut while loading after login #14490
• those components will be migrated to functional components sooner or later

[thesahindia]

@youssef-lr, I think we should hold this because there is a possibility that it could be fixed in #14490.

[youssef-lr]

@thesahindia thanks for linking that issue. Yeah I agree. I'm gonna go ahead and put this on hold.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/14490: No data displayed in options list if component using report data is rendered too early #17349

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

This one was put on hold and fixed elsewhere, is that right @youssef-lr @thesahindia? Are there payments needed for this one?

[aimane-chnaif]

This was fixed in #17349
I think I am only the one for reporting bonus

[lschurr]

Great, could you apply to the job here @aimane-chnaif - https://www.upwork.com/jobs/~01dfce6726bdf40e71

[aimane-chnaif]

@lschurr applied, thanks

[lschurr]

Once payment is made, can we close this one @youssef-lr @thesahindia @aimane-chnaif?

[youssef-lr]

Once payment is made, can we close this one @youssef-lr @thesahindia @aimane-chnaif?

Yup!

[lschurr]

Great! Reporting bonus is paid. Closing this one.