[$1000] User avatar preview shows attachment icon instead of the image itself.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account
2. Open 2 tabs, from the first tab try to change the user avatar.
3. From second tab, go to any report, wait for the avatar changes, click on user to preview the avatar.
4. Notice that the preview modal shows the attachment icon, instead of the user avatar.

Expected Result:

It should show user avatar instead of attachment icon.

Actual Result:

The preview modal shows the attachment icon, instead of the user avatar.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-03-31.at.18.33.00.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680262415387269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0103169638f95d2d0e
• Upwork Job ID: 1646964132027346944
• Last Price Increase: 2023-04-14

[MelvinBot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@johncschuster Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MelvinBot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[slafortune]

I was able to reproduce this once I removed by current profile pic and reloaded it.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0103169638f95d2d0e

[MelvinBot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[MelvinBot]

Triggered auto assignment to @MonilBhavsar (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Old picture appears in preview

What is the root cause of that problem?

The source state is only assigned with source props in constructor. So that, when source props is changed source state is still old value. That's why old picture appears in preview.

App/src/components/AttachmentModal.js

Line 85 in 2d0ef06

source: props.source,

What changes do you think we should make in order to solve the problem?

We should add componentDidUpdate function to update source state when source props is changed.

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.12-04-2023.22.21.19.webm

[avi-shek-jha]

This issue is being solved here I guess.
#16528 (comment)

[MonilBhavsar]

Agree, seems like it will be solved by #16528

[slafortune]

updating to weekly

[MonilBhavsar]

The corresponding PR is deployed to production. Testing this now

[MonilBhavsar]

Seems to have been fixed
@slafortune to be double sure, could you please test it and close this issue

Screen.Recording.2023-05-01.at.8.42.42.PM.mov

[mananjadhav]

Checked on staging and looks fixed to me as well.

user-avatar-upload.mov

[mananjadhav]

@MonilBhavsar @slafortune Still waiting on anything?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[MonilBhavsar]

Thanks!
We can close this