Profile - System allows you to save a dot instead of any information for home address fields

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #15880

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings -> Profile -> Personal details -> Home address
4. Enter dots . in any field -> Save

Expected Result:

An error is shown

Actual Result:

The information is saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6005903_Record_2023-04-04-19-09-06.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

@kbecciv I'm unsure if this was found while testing #15880 since the layout is different. In the video, the zip code field and state field are adjacent but with the changes from #15880 , both the inputs have their own row.

Moreover, due to the zip code validation, it is not possible to save only . for ALL fields. At least for the zip input, you cannot use dots but yeah this can be done for other fields if the zip code input is correct.

[kbecciv]

@Prince-Mendiratta QA team found this issue while executing the PR above. We want to check with Engeneers if it's expected behavior.

[0xmiros]

This is not a bug but enhancement of validation.
@Beamanator do we need more strict validation for all fields than just empty check?

[Beamanator]

I assigned myself b/c I worked on this page in the recent past

In OldDot we don't validate exactly what's in these address fields, just that they're > 1 character & < 50 characters. So I think it's fine not to have explicit regex for every single field, or else we should probably do that for all forms in the App.

[slafortune]

Since this is reported by applause, there will be no payout for reporting. Will there still be a C+ for review on this @Beamanator ? If not, I'll unassign myself.

[MelvinBot]

@Beamanator, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

@slafortune yes exactly right, this is not a "bug" anyway so you can unassign yourself, I'll just keep this open till @kbecciv can confirm we are good to go - I'm not sure if we need to update any testrail cases or if we can just close this out

[kbecciv]

@Beamanator it doesn't need to update TestRail

[Beamanator]

Ok great sounds good! Let's close this then 👍