Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessible Pressables] Migrate TouchableOpacity to accessible pressables #16991

Closed
roryabraham opened this issue Apr 6, 2023 · 5 comments
Closed
Labels
Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

HOLD on #16988

Description

List of components to migrate for this issue:

done? Component New component to use
OptionRow PressableWithFeedback
OptionRowLHN PressableWithFeedback
SidebarLinks PressableWithoutFeedback
Switch PressableWithFeedback
RadioButtonWithLabel PressableWithFeedback
CheckboxWithLabel PressableWithFeedback
ReportActionCompose PressableWithoutFeedback
CalendarPicker PressableWithFeedback/Without
ResendValidationForm PressableWithFeedback
BaseValidateCodeForm PressableWithFeedback
PasswordForm PressableWithFeedback
WorkspaceMembersPage PressableWithFeedback
IOUModal PressableWithFeedback x2
CurrencySymbolButton PressableWithoutFeedback
CollapsibleSection PressableWithFeedback (for haptics)
ChangeExpensifyLoginLink PressableWithFeedback
@roryabraham roryabraham added Monthly KSv2 NewFeature Something to build that is a new item. labels Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Apr 6, 2023
@roryabraham
Copy link
Contributor Author

cc @robertKozik

@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham changed the title [HOLD][Accessible Pressables] Migrate TouchableOpacity to accessible pressables [Accessible Pressables] Migrate TouchableOpacity to accessible pressables Apr 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables Apr 27, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 2, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2023
@roryabraham roryabraham added Weekly KSv2 and removed Monthly KSv2 labels May 2, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@roryabraham
Copy link
Contributor Author

We have been making great progress on this and only have 3 Touchable components left on main. I'm going to close this tracking issue since we've got the GH project we're using instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants