Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep #17012

Closed
roryabraham opened this issue Apr 6, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate IOUPreview to use PressableWithoutFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014fe7eaa4b126b7f2
  • Upwork Job ID: 1666897817357955072
  • Last Price Increase: 2023-06-08
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 1][Accessible Pressable] Migrate BankAccountStep [Group 1][Accessible Pressable] Migrate BankAccountStep May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

@roryabraham can you assign me to this one?

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables May 22, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 23, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels May 31, 2023
@melvin-bot melvin-bot bot changed the title [Group 1][Accessible Pressable] Migrate BankAccountStep [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep May 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 6, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Jun 8, 2023

@PauloGasparSv can you please add BZ member or reassign @flaviadefaria to handle payment?

@0xmiros
Copy link
Contributor

0xmiros commented Jun 8, 2023

I am eligible for C+ compensation for internal PR review

@flaviadefaria
Copy link
Contributor

@roryabraham @PauloGasparSv since this GH never got an internal or external label added I'm a bit confused about how to handle the payment for @robertKozik is this handled separately?

@roryabraham
Copy link
Contributor Author

@robertKozik works for Software Mansion and invoices us separately. We just need to pay @0xmiroslav for the C+ review. I've been assigning all these migration issues a bounty amount of $250 instead of $1000 because they're quite simple to review and there's a lot of them.

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep [$1000] [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014fe7eaa4b126b7f2

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 8, 2023
@roryabraham roryabraham changed the title [$1000] [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep [$250] [HOLD for payment 2023-06-07] [Group 1][Accessible Pressable] Migrate BankAccountStep Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Upwork job price has been updated to $250

@roryabraham roryabraham assigned 0xmiros and unassigned Gonals and sobitneupane Jun 8, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

📣 @0xmiroslav You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor Author

Added the external label just to generate the upwork job. @flaviadefaria to recap simply, the only payment due here is $250 to @0xmiroslav for the C+ review.

@flaviadefaria
Copy link
Contributor

Thanks @roryabraham for confirming! I believe the C+ review is a flat $1000 actually so I'll update the GH and issue payment for them.

@0xmiros
Copy link
Contributor

0xmiros commented Jun 9, 2023

We started compensating $250 for these kinds of issues. Not sure about this issue whether 250 or original 1k since the work is already done before that announcement. Similar case: #17006 (comment)

@roryabraham
Copy link
Contributor Author

We can pay $1000 in this case because the work was completed before we set the lower bounty amount, but @flaviadefaria for this issue and similar issues it's possible you'll see lower bounty amounts than the standard $1000, and in those cases the C+ payout will be lower as well

@flaviadefaria
Copy link
Contributor

Got it! Thank you both for clarifying. I'll issue the $1000 payment now.

@flaviadefaria
Copy link
Contributor

Offer sent!

@0xmiros
Copy link
Contributor

0xmiros commented Jun 9, 2023

Accepted thanks

@flaviadefaria
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

7 participants