Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Group 2][Accessible Pressable] Migrate OptionRowLHN #17014

Closed
roryabraham opened this issue Apr 6, 2023 · 4 comments
Closed

[Group 2][Accessible Pressable] Migrate OptionRowLHN #17014

roryabraham opened this issue Apr 6, 2023 · 4 comments
Assignees
@Skalakid
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

HOLD on #16988

Description

Migrate OptionRowLHN to use PressableWithFeedback
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

Sign in to view
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 2][Accessible Pressable] Migrate OptionRowLHN [Group 2][Accessible Pressable] Migrate OptionRowLHN May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@Skalakid
Copy link
Contributor

Hi can you assign me to this one, please?

@Skalakid Skalakid mentioned this issue May 26, 2023
Closed
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 26, 2023
@Skalakid
Copy link
Contributor

Skalakid commented Jun 6, 2023

@roryabraham In the meantime #16079 was merged into main and it changes TouchableOppacity into PressableWithSecondaryInteraction, so in this case, is my PR still needed? PressableWithSecondaryInteraction will be migrated to GenericPressable in #17047 by @robertKozik

@roryabraham
Copy link
Contributor Author

Oh yeah, looks like this issue isn't needed anymore.

@github-project-automation github-project-automation bot moved this from Todo to Done in Accessible Pressables Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skalakid Skalakid

Labels
Monthly KSv2 NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Accessible Pressables
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slafortune @MelvinBot @Skalakid @roryabraham