Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-05-25] [Group 2][Accessible Pressable] Migrate Switch #17016

Closed
roryabraham opened this issue Apr 6, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate Switch to use PressableWithFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f57992b9f80d736b
  • Upwork Job ID: 1664321781375213568
  • Last Price Increase: 2023-06-01
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 Monthly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@robertKozik robertKozik mentioned this issue May 5, 2023
57 tasks
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 2][Accessible Pressable] Migrate Switch [Group 2][Accessible Pressable] Migrate Switch May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

Hi, If you could assign me to it. PR is ready here: #18512 (comment)

@roryabraham
Copy link
Contributor Author

Assigned

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables May 16, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels May 18, 2023
@melvin-bot melvin-bot bot changed the title [Group 2][Accessible Pressable] Migrate Switch [HOLD for payment 2023-05-25] [Group 2][Accessible Pressable] Migrate Switch May 18, 2023
@melvin-bot melvin-bot bot removed the Overdue label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@sobitneupane
Copy link
Contributor

@roryabraham Can you please assign me to this issue. I reviewed the associated PR.

@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

@sobitneupane, @robertKozik Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

@sobitneupane, @robertKozik 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@roryabraham
Copy link
Contributor Author

Looks like we need to make a C+ review payment here.

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 1, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-25] [Group 2][Accessible Pressable] Migrate Switch [$1000] [HOLD for payment 2023-05-25] [Group 2][Accessible Pressable] Migrate Switch Jun 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f57992b9f80d736b

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Triggered auto assignment to @flaviadefaria (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

Triggered auto assignment to @mountiny (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 1, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@roryabraham
Copy link
Contributor Author

@flaviadefaria The only TODO here is to pay @sobitneupane $1000 for the PR review. Then we can close this out.

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@flaviadefaria
Copy link
Contributor

Offer sent!

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@flaviadefaria
Copy link
Contributor

Paid!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

7 participants