Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Group 3][Accessible Pressable] Migrate HeaderView #17033

Closed
roryabraham opened this issue Apr 6, 2023 · 24 comments
Closed

[$250] [Group 3][Accessible Pressable] Migrate HeaderView #17033

roryabraham opened this issue Apr 6, 2023 · 24 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate HeaderView to use PressableWithoutFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01763b84324b17412b
  • Upwork Job ID: 1664586780671045632
  • Last Price Increase: 2023-06-11
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 3][Accessible Pressable] Migrate HeaderView [Group 3][Accessible Pressable] Migrate HeaderView May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@Skalakid
Copy link
Contributor

Can you assign me to this one, please? :D

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jun 1, 2023
@grgia grgia added the External Added to denote the issue can be worked on by a contributor label Jun 2, 2023
@grgia grgia self-assigned this Jun 2, 2023
@melvin-bot melvin-bot bot changed the title [Group 3][Accessible Pressable] Migrate HeaderView [$1000] [Group 3][Accessible Pressable] Migrate HeaderView Jun 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01763b84324b17412b

@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jun 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 2, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

📣 @Skalakid You have been assigned to this job by @grgia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Expensify Expensify deleted a comment from melvin-bot bot Jun 2, 2023
@grgia
Copy link
Contributor

grgia commented Jun 2, 2023

Labels and assignments were acting funky here, sorry for any extra pings!

@TheSonOfSocrates
Copy link

Hello, Nice to meet you.
I'm a senior engineer.
I can solve this issue in 2 days.
Allow me to list brief description.

  1. Import the PressableWithoutFeedback component from the react-native library.

    import React, { useState } from 'react';
    import { View, Text, PressableWithoutFeedback } from 'react-native';

  2. Change the TouchableWithoutFeedback component to PressableWithoutFeedback.

    <PressableWithoutFeedback
    onPress={() => {
    console.log('Header pressed!');
    }}

    Header
  3. Test app to make sure that the HeaderView is working properly.

Here is the complete code for the HeaderView component using the PressableWithoutFeedback component:

import React, { useState } from 'react';
import { View, Text, PressableWithoutFeedback } from 'react-native';

const styles = {
header: {
height: 40,
width: 100,
backgroundColor: 'red',
},
headerText: {
fontSize: 20,
color: 'white',
},
};

const HeaderView = () => {
const [isPressed, setIsPressed] = useState(false);

return (
<PressableWithoutFeedback
onPress={() => {
setIsPressed(!isPressed);
console.log('Header pressed!');
}}
>

{isPressed ? 'Pressed' : 'Not pressed'}


);
};

export default HeaderView;

I hope to meet you soon.
Thank you.

@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

📣 @JavaSuperDev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@TheSonOfSocrates
Copy link

Hello, Nice to meet you.
I'm a senior engineer.
I can solve this issue in 2 days.
Allow me to list brief description.

  1. Import the PressableWithoutFeedback component from the react-native library.

    import React, { useState } from 'react';
    import { View, Text, PressableWithoutFeedback } from 'react-native';

  2. Change the TouchableWithoutFeedback component to PressableWithoutFeedback.

    <PressableWithoutFeedback
    onPress={() => {
    console.log('Header pressed!');
    }}

    Header
  3. Test app to make sure that the HeaderView is working properly.

Here is the complete code for the HeaderView component using the PressableWithoutFeedback component:

import React, { useState } from 'react';
import { View, Text, PressableWithoutFeedback } from 'react-native';

const styles = {
header: {
height: 40,
width: 100,
backgroundColor: 'red',
},
headerText: {
fontSize: 20,
color: 'white',
},
};

const HeaderView = () => {
const [isPressed, setIsPressed] = useState(false);

return (
<PressableWithoutFeedback
onPress={() => {
setIsPressed(!isPressed);
console.log('Header pressed!');
}}
>

{isPressed ? 'Pressed' : 'Not pressed'}


);
};

export default HeaderView;

I hope to meet you soon.
Thank you.

@Skalakid
Copy link
Contributor

Skalakid commented Jun 2, 2023

HI @grgia the PR is ready :D but I think I don't understand why External label was added to this issue after I finished my work

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Jun 2, 2023

why External label was added to this issue

@Skalakid nvm, it's just to pull up C+ and engineer for PR review
In the future, please link issue correctly in PR description in order not to break github automations:

$ https://github.com/Expensify/App/issues/17033

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

@grgia, @maddylewis, @Skalakid, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

@roryabraham roryabraham changed the title [$1000] [Group 3][Accessible Pressable] Migrate HeaderView [$250] [Group 3][Accessible Pressable] Migrate HeaderView Jun 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 11, 2023

Upwork job price has been updated to $250

@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2023

@grgia, @maddylewis, @Skalakid, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@maddylewis
Copy link
Contributor

@aimane-chnaif - could you provide an update on where we are with this one? thanks!

also, I am going OOO until June 20. Is the only thing needed from me to issue payment? if so, and payment is due before June 20, please re-apply the BUG label so that another BZ member can process payment.

@aimane-chnaif
Copy link
Contributor

PR hit staging yesterday so payment will be done after June 20 and no need to re-assign

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

@grgia, @maddylewis, @Skalakid, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@grgia
Copy link
Contributor

grgia commented Jun 22, 2023

@maddylewis I think this issue is ready for payment

@maddylewis
Copy link
Contributor

great - i can do that 👍

to confirm:

@aimane-chnaif
Copy link
Contributor

@maddylewis @Skalakid is from SWM, I am the only person for upwork payment

@maddylewis
Copy link
Contributor

got it - ty for clarifying. ill get the offer sent over in just a few.

@maddylewis
Copy link
Contributor

this is paid!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
No open projects
Status: Done
Development

No branches or pull requests

9 participants