Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage #17035

Closed
roryabraham opened this issue Apr 6, 2023 · 19 comments
Closed

[$250] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage #17035

roryabraham opened this issue Apr 6, 2023 · 19 comments
Assignees
@madmax330 @parasharrajat @jliexpensify @Skalakid
Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023 •
edited by melvin-bot bot
Loading

HOLD on #16988

Description

Migrate WorkspaceInitialPage to use PressableWithoutFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0131b54ef3b915f78a
  • Upwork Job ID: 1666114362453778432
  • Last Price Increase: 2023-06-06
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

Sign in to view
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 3][Accessible Pressable] Migrate WorkspaceInitialPage [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@Skalakid
Copy link
Contributor

Skalakid commented Jun 5, 2023

Can you assign me to this one?

@Skalakid Skalakid mentioned this issue Jun 5, 2023
Merged
57 tasks
@muxriddinmuqimov77
Copy link

Can you assign me to this one?

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 6, 2023
@melvin-bot melvin-bot bot changed the title [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage [$1000] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0131b54ef3b915f78a

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 Overdue labels Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 6, 2023
@roryabraham roryabraham changed the title [$1000] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage [$250] [Group 3][Accessible Pressable] Migrate WorkspaceInitialPage Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Upwork job price has been updated to $250

@roryabraham roryabraham assigned madmax330 and unassigned deetergp Jun 6, 2023
@Vishrut19
Copy link
Contributor

Vishrut19 commented Jun 6, 2023 •
edited
Loading

I want to work on it @jliexpensify

@roryabraham
Copy link
Contributor Author

Hi everyone 👋🏼

@Skalakid has a PR open for this here. The only payment that will be due is the C+ payment, and because these PRs are pretty simple we're going to start using a going rate of $250 for the C+ review, similar to what we're doing for functional component migrations and what we will do for the TypeScript migration.

Also, @muxriddinmuqimov77 @Vishrut19 for some additional context @Skalakid was hired separately and pre-approved to work on this issue. Most often, external contributors need to follow a different process to apply to work on our open-source jobs. That process is outlined in detail in our Contributing Guidelines.

@melvin-bot melvin-bot bot added the Overdue label Jun 8, 2023
@madmax330
Copy link
Contributor

@parasharrajat can you reviews the PR?

@melvin-bot melvin-bot bot removed the Overdue label Jun 9, 2023
@parasharrajat
Copy link
Member

Yes. Testing it in 15 minutes.

@melvin-bot melvin-bot bot added the Overdue label Jun 12, 2023
@madmax330
Copy link
Contributor

PR was merged, not overdue

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@roryabraham
Copy link
Contributor Author

PR is on staging, going to make this a weekly while we wait through the regression period.

@roryabraham roryabraham added Weekly KSv2 and removed Help Wanted Apply this label when an issue is open to proposals by contributors Daily KSv2 labels Jun 13, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@parasharrajat
Copy link
Member

For me:
🎀 👀 🎀 C+ reviewed

@jliexpensify
Copy link
Contributor

Hired @parasharrajat

@jliexpensify
Copy link
Contributor

@parasharrajat are you running into issues accepting my offer in Upworks? I swear something is broken on their end...

@parasharrajat
Copy link
Member

parasharrajat commented Jun 28, 2023 •
edited
Loading

Apologies. I forget to inform you. I am holding payments for a few days due to https://expensify.slack.com/archives/C02NK2DQWUX/p1686871517189609. I will ping you back based on the result.

@parasharrajat
Copy link
Member

@jliexpensify This is paid via reimbursements. We are good to close this.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madmax330 madmax330

@parasharrajat parasharrajat

@jliexpensify jliexpensify

@Skalakid Skalakid

Labels
External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
No open projects
Accessible Pressables
Status: Done
Milestone
No milestone
Development

No branches or pull requests
10 participants
@deetergp @madmax330 @MelvinBot @parasharrajat @jliexpensify @Skalakid @roryabraham @Vishrut19 @kadiealexander @muxriddinmuqimov77