Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-21] [$250] [Group 5][Accessible Pressable] Migrate RadioButton #17049

Closed
roryabraham opened this issue Apr 6, 2023 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate RadioButton to use PressableWithFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013b392f488b33d589
  • Upwork Job ID: 1666106329244422144
  • Last Price Increase: 2023-06-11
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 5][Accessible Pressable] Migrate RadioButton [Group 5][Accessible Pressable] Migrate RadioButton May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@Skalakid
Copy link
Contributor

Skalakid commented Jun 6, 2023

I will do this one

@luacmartins
Copy link
Contributor

Temporarily adding the bug label to get a C+ assigned for testing.

@melvin-bot melvin-bot bot removed the Overdue label Jun 6, 2023
@luacmartins luacmartins added Overdue Bug Something is broken. Auto assigns a BugZero manager. labels Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jun 6, 2023
@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Daily KSv2 labels Jun 6, 2023
@melvin-bot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot changed the title [Group 5][Accessible Pressable] Migrate RadioButton [$1000] [Group 5][Accessible Pressable] Migrate RadioButton Jun 6, 2023
@luacmartins luacmartins removed the Bug Something is broken. Auto assigns a BugZero manager. label Jun 6, 2023
@luacmartins
Copy link
Contributor

@isabelastisser This is a new feature. I just added the Bug label to get a C+ assigned for review/testing.

@luacmartins
Copy link
Contributor

@MahmudjonToraqulov we already have a PR up to fix this

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

📣 @Skalakid You have been assigned to this job by @luacmartins!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@MahmudjonToraqulov
Copy link
Contributor

@MahmudjonToraqulov we already have a PR up to fix this

Got it.Thanks

@luacmartins luacmartins added the Reviewing Has a PR in review label Jun 7, 2023
@roryabraham roryabraham changed the title [$1000] [Group 5][Accessible Pressable] Migrate RadioButton [$250] [Group 5][Accessible Pressable] Migrate RadioButton Jun 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 11, 2023

Upwork job price has been updated to $250

@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

@luacmartins, @allroundexperts, @isabelastisser, @Skalakid Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor

PR is merged

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 14, 2023
@melvin-bot melvin-bot bot changed the title [$250] [Group 5][Accessible Pressable] Migrate RadioButton [HOLD for payment 2023-06-21] [$250] [Group 5][Accessible Pressable] Migrate RadioButton Jun 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham
Copy link
Contributor Author

The only payment due here is $250 to @allroundexperts

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 21, 2023
@isabelastisser
Copy link
Contributor

@allroundexperts I set you the offer in Upwork, please accept it and I will process the payment. Thanks!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 22, 2023
@allroundexperts
Copy link
Contributor

@allroundexperts I set you the offer in Upwork, please accept it and I will process the payment. Thanks!

Accepted.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants