[PAID] [$1000] The months are not dynamically updated to Spanish language when language preference is changed from the other device

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to android and login with User A (should have english language preference at first)
2. Go to Settings > Profile > Personal details. Click on the date of birth field.
3. See that the months are in English and do not leave this page (don't press back or save)
4. Now go to mweb chrome with the same User A and change the language to Spanish
5. Go back to android and notice that the header 'Date of birth' and the placeholder 'AAAA-MM-DD' has been dynamically updated , but the months are still shown in English. Thus, in the same page , few components (header/placeholder) gets updated dynamically whereas the other few components (months) are not updated.

Expected Result:

The months should also be updated dynamically when language has been changed from the other device in a similar way how the header and the placeholder gets updated

Actual Result:

Months doesn't update dynamically when the language is changed from the other device whereas, for the same page, header and placeholder gets updated properly

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.96-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

update.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680768933826169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b3f907903b77b6d
• Upwork Job ID: 1648104574408331264
• Last Price Increase: 2023-04-17

[MelvinBot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@tjferriss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@tjferriss Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tjferriss]

I'm unable to reproduce using these steps.

[priya-zha]

@tjferriss Can you try this with a real device. I tried it again and it's still reproducible.

[MelvinBot]

@tjferriss Eep! 4 days overdue now. Issues have feelings too...

[strepanier03]

I have a Google Pixel 6 Pro on Android 13. I'll give this a shot.

[strepanier03]

I am able to recreate this behavior.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010b3f907903b77b6d

[MelvinBot]

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, when we are on the Date Picker page and we change the user locale from another device, the date picker itself does not re render with the updated language changes, leading to only partial locale change.

What is the root cause of that problem?

The root cause behind this issue is that instead of storing the month and weekday names in the react state, we have declared them as a property, which is not updated on locale change.
https://github.com/Expensify/App/blob/e56b9c76e8d2f058625c9dc729d700e12130c7f8/src/components/CalendarPicker/index.jsL22-L23

What changes do you think we should make in order to solve the problem?

We store monthNames and daysOfWeek in the state. We add a new condition to the componentDidUpdate such that if there are changes to the preferred locale, we udpate the state with the new locale.

To facilitate these changes in a neat manner, we will create a function getYearAndMonthData:

getYearAndMonthData() {
    return {
        monthNames: _.map(moment.localeData(this.props.preferredLocale).months(), Str.recapitalize),
        daysOfWeek: _.map(moment.localeData(this.props.preferredLocale).weekdays(), day => day.toUpperCase()),
    };
}

Using this function, we will set the state in the constructor. In the componentDidUpdate condition as well, we will directly call this.setState(this.getYearAndMonthData());.

This will ensure that the items displayed in the date picker are updated as well once the locale is updated.

[MelvinBot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

📣 @allroundexperts You have been assigned to this job by @grgia!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allroundexperts]

PR created #17780

[strepanier03]

I am going to be OoO from April 26-May 3. I plan to leave this GH assigned to me during my out-of-office as it likely won't need my action before I return.

If something changes and action is needed from the BugZero team, please reach out in #expensify-open-source to request help from another team member.

Thanks, chat with you when I get back!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: use month names and daysOfWeek directly in the render method #17780

If no regressions arise, payment will be issued on 2023-05-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @priya-zha - $250
• Contributor that fixed the issue - @allroundexperts - $1000 + $500 (speed bonus) = $1500
• Contributor+ that helped on the issue and/or PR - @thesahindia - $1000 + $500 (speed bonus) = $1500

Speed bonus analysis - PR submitted April 21 / PR merged April 24 = Eligible

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR: Feat: New Date Picker Design #15343
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15343/files#r1186457607
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1683317117553869
• [@thesahindia] Determine if we should create a regression test for this bug.: Yes, we should
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/281513

[strepanier03]

I'm just back from out of office so catching up on this now.

---

@allroundexperts and @thesahindia - I have hired you both to the Upwork job and will check to pay today.

@thesahindia if you can work on the BZ checklist I can check off boxes or make the reg test GH as needed.

---

@priya-zha - I have also hired you toa bug reporting job in Upwork.

[strepanier03]

I'll check in later today to pay anything I can.

[priya-zha]

Thanks. Accepted the offer.

[strepanier03]

@priya-zha and @allroundexperts - I've paid you both via Upwork.

I'll check tomorrow for paying @thesahindia

[thesahindia]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:

#15343

• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/15343/files#r1186457607

• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1683317117553869

• [@thesahindia] Determine if we should create a regression test for this bug.

Yes, I think we should.

• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Instead of adding a regression test case for this specific page we should test this behaviour on all the pages.

Regression test proposal

1. Open new dot at two devices
2. Go to any page that you wanna test on device 1
3. At device 2 go to settings > preferences > Language
4. Change the language
5. Go to device 1 and verify the text got translated to the chosen language

[thesahindia]

I'll check tomorrow for paying @thesahindia

Accepted, thanks!

[strepanier03]

Thank you @thesahindia, I'll take the rest from here and pay you in Upwork as well.

[strepanier03]

All set here. Checklist is done, reg test is ready, and everyone has been paid.

---

Thank you everyone for working on this and together with the team.