Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] mWeb - Chat - The page starts to shake when user went back to the conversation #17147

Closed
1 of 6 tasks
kbecciv opened this issue Apr 7, 2023 · 16 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app.
  2. Paste the links in chat conversation ( https://staging.new.expensify.com/r/6821704960193694/participants or https://staging.new.expensify.com/r/6821704960193694/settings
  3. Tap on one of it.
  4. Tap on Go back to Home page option.
  5. Back again to the conversation.

Expected Result:

The page should not shake when user returns to the conversation

Actual Result:

The page starts to shake when user went back to the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.96.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6010026_Ws_0704.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 7, 2023
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@MelvinBot
Copy link

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

@puneetlath
Copy link
Contributor

@kbecciv what do you mean by "drag"? I don't quite follow what the bug is.

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@kbecciv
Copy link
Author

kbecciv commented Apr 11, 2023

@puneetlath The page was shaking when user went back to the conversation.

@kbecciv kbecciv changed the title mWeb - Chat - The page starts to drag when user went back to the conversation mWeb - Chat - The page starts to shake when user went back to the conversation Apr 11, 2023
@puneetlath
Copy link
Contributor

Ah, I see. @mountiny this seems navigation-related. Do you think we should put it on hold for that project?

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@mountiny
Copy link
Contributor

yes I think this might be resolved after the refactor as we move to the stack based navigation

@mountiny mountiny changed the title mWeb - Chat - The page starts to shake when user went back to the conversation [HOLD #11768] mWeb - Chat - The page starts to shake when user went back to the conversation Apr 11, 2023
@mountiny
Copy link
Contributor

mountiny commented Apr 11, 2023

On hold for #11768

Added it to the tracking

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels Apr 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 20, 2023
@puneetlath
Copy link
Contributor

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@puneetlath
Copy link
Contributor

@JmillsExpensify should I be assigning you since this is a navigation issue. It looks like you're assigned on all the others (I only spot-checked) in the tracking issue.

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Ah yeah go for it. I just missed this one. We're hopefully going to unleash all of these issues soon.

@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@melvin-bot melvin-bot bot added the Overdue label May 25, 2023
@JmillsExpensify
Copy link

Still on hold, though we should be taking a lot of these issues off hold next week.

@melvin-bot melvin-bot bot removed the Overdue label May 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 8, 2023
@JmillsExpensify
Copy link

Going to start testing these issues this week.

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 22, 2023
@JmillsExpensify
Copy link

Just re-tested this one. The page didn't shake, and in addition, when I access personal details via a link, the back button currently went to the profile. All looking good, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants