[HOLD for payment 2023-05-22] [$1000] User list is not dynamically updated on invite members page (works fine on manage members)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app on any device and login with user A (hereafter called as device 1)
2. Open the app in any other platform (mac chrome was used to test) and login with user A (hereafter called as device 2)
3. Open settings->workspaces->any workspace-> manage members on both the devices
4. From any one device, remove 1 user and see that it is dynamically updated on device 2
5. Open invite members on both the device
6. From any one device, select any user and invite the user, check on other device that user still exists, select and unselect that user to see that now it gets updated

Expected Result:

App should update invite members list dynamically across devices as it does on manage members page

Actual Result:

App does not update invite members list dynamically across devices if any change is done on any one device

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

invite.members.not.updated.mweb.chrome.mp4

invite.members.not.updated.web.chrome.mp4

Recording.195.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1681057765637049
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5f9213cd9c64af4
• Upwork Job ID: 1648031410778984448
• Last Price Increase: 2023-05-01

[MelvinBot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[CortneyOfstad]

Tackling this today!

[CortneyOfstad]

I wasn't able to recreate this. I created a workspace under cortney@expensify.com and invited accountant.cort@expensicorp.com. The invite updated both on my mobile app on iPhone and on Chrome on my Mac correctly and the same for removing accountant.cort@.

Going to re-assign this as I am heading on sabbatical but @kavimuru is @dhanashree-sawant still able to reproduce this?

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhanashree-sawant]

Hi @NicMendonca, @CortneyOfstad, I was still able to recreate. The key here is to do steps together on mac and android, deleting user updates the list on android but when invite member page is open on both and from mac if we invite someone, on android we can still see and select that person.

[NicMendonca]

@dhanashree-sawant sorry, just to confirm -- this is only happening on web (mac) and android? Have you been able to reproduce with other platform combinations?

[dhanashree-sawant]

Hi @NicMendonca, leaving ios, I have tested combination with all other platforms i.e. web mac, web windows, mac application, android application, android app and was able to reproduce with them.

[NicMendonca]

Okay, I can reproduce this when the "invite new members" is open.

So the expected behaviour would be that the user be dynamically removed from this list:

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01e5f9213cd9c64af4

[MelvinBot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

[PauloGasparSv]

Not overdue, App P.R. was merged 1 hour ago : )

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: User list is not dynamically updated on invite members page #18580

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[PauloGasparSv]

Not overdue!

[NicMendonca]

Going OOO until June 5th so assigning a buddy to this GH to issue payment 🙏

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bfitzexpensify]

offers sent out @dhanashree-sawant @dukenv0307 @Santhosh-Sellavel

[dhanashree-sawant]

Hi @bfitzexpensify, thanks I have accepted the offer.

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@NicMendonca] Link the GH issue for creating/updating the regression test once the above steps have been agreed upon: N/A

@PauloGasparSv
This doesn't look like a regression to me as it's not broken. We missed handling this case for the invite page which was added some time ago, so it's more or less an improvement. So adding a test case alone should be enough if it's not already. Let me know your thoughts, thanks!

[PauloGasparSv]

This doesn't look like a regression to me as it's not broken. We missed handling this case for the invite page which was added some time ago, so it's more or less an improvement. So adding a test case alone should be enough if it's not already. Let me know your thoughts, thanks!

I agree, don't think there is a need for a regression test
Feel free to check that off : )

[Santhosh-Sellavel]

Cool, thanks!

[bfitzexpensify]

All payments complete, checklist done. Thanks for the work here! Closing this out