[HOLD for payment 2023-07-26] [$2000] Desktop - App is show endless spinner when tap popup Open app in "New Expensify

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #16869

Action Performed:

1. Open staging.expensify.com, login with account A.
2. Open staging.new.expensify.com and login with same account.
3. Download and open the staging Desktop App, if you haven't already.
4. Click on the concierge button at bottom right on staging.expensify.com/inbox
5. Tap on the "Open app in "New Expensify" popup.

Expected Result:

Desktop App should be open and user login.

Actual Result:

Desktop App is show endless spinner.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.99.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6016486_desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0151b55ece236c38ac
• Upwork Job ID: 1646650899463368704
• Last Price Increase: 2023-04-24

Issue Owner

Current Issue Owner: @mallenexpensify

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0151b55ece236c38ac

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[mallenexpensify]

Was able to reproduce, you might not need to do 'all' the steps, maybe try

• Have staging version of desktop open, working and logged in with User A
• Go to staging.expensify.com on web, log in with User A,
• Click concierge button in bottom right
• Click 'Open New Expensify' in the app
• Observe spinner.

Reckon this is internal.
Refreshing 'fixed' it.
I didn't see any errors in the console either

[s77rt]

I was able to reproduce too.
Unrelated but on staging.new.expensify.com we are not getting redirected to the concierge chat.

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Eeeps, didn't know (or forgot) I also needed to apply Engineering along with Internal. @MariaHCD can you take a look plz?

[MariaHCD]

I'm able to reproduce the issue as well. As an additional note, if you're already signed in on Desktop, you get a Session Expired error instead of a loading spinner:

[MariaHCD]

After doing some more testing, I see that the infinite spinner isn't always reproducible, I tested several times and was able to load the desktop app without issues:

Screen.Recording.2023-04-17.at.11.49.51.AM.mov

[MariaHCD]

So it looks like the "Open in New Expensify" button from web does work (the requests to SignInWithShortLivedAuthToken and OpenApp succeed, internal logs here) but seems to fail when you've just newly/recently logged into your account on OldDot.

I did notice that when the infinite spinner was shown on desktop, the requests to SignInWithShortLivedAuthToken and OpenApp were not sent:

Screen.Recording.2023-04-17.at.11.57.59.AM.mov

So that makes me think that perhaps the App is not sending those requests when opened from web. In this case, I think this can be an external issue.

[MelvinBot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

Upwork job price has been updated to $2000

[0xmiros]

yeah, fine with team decision, though PR work was worthy of 2k based on complexity.

[pecanoro]

Discussing internally!

[pecanoro]

@mallenexpensify is OOO today!

[mallenexpensify]

@pecanoro and I are discussing. I'm mostly off this week so it likely won't be til next week that I'm able to issue payment

[mallenexpensify]

Rocio and I discussed and we settled on $1000 for the payment. Thanks for the help.

Issue reporter: Applause
Contributor: @ntdiary - Paid $1000 via Upwork
Contributor+: @0xmiroslav is due $1000 - can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01a8ecdf6b5c6c1793

[pecanoro]

@0xmiroslav Do we need to HOLD payment on this one as well?

[0xmiros]

yes, please

[pecanoro]

Still on HOLD!

[pecanoro]

@0xmiroslav Should we still hold?

[0xmiros]

yes please close this. I am tracking and will ping here when ready

[mallenexpensify]

I bumped to Monthly and removed the bug label. I'd prefer not to close til payment's been made (because I don't want to forget)

[mallenexpensify]

Will close cuz @0xmiroslav is keeping tab on his issues.