-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-16] Show green dot in LHN when user is mentioned #17887
Comments
Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~01f14c3b5869ba2233 |
Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new. |
@0xmiroslav got auto-assigned by puller bear to review the PR, so assigning them here too. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Contract sent to @0xmiroslav. |
Paid! Thanks everyone! |
As part of the mentions project, we will be adding a green dot in the LHN when a user has unread mentions. The green dot icon will be added to the OptionRowLHN.js next to the pin and pencil icon. Similarly to the brickRoadIndicator, we will use the Expensicons.DotIndicator.
The green dot should be placed in the LHN when the
lastMentionedTime
on the report is later than thelastReadTime
. This is very similar to the logic for marking a report as unread in the LHN.The details of the implementation are described in the doc here.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: