Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-16] Show green dot in LHN when user is mentioned #17887

Closed
puneetlath opened this issue Apr 24, 2023 · 8 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Apr 24, 2023

As part of the mentions project, we will be adding a green dot in the LHN when a user has unread mentions. The green dot icon will be added to the OptionRowLHN.js next to the pin and pencil icon. Similarly to the brickRoadIndicator, we will use the Expensicons.DotIndicator.

The green dot should be placed in the LHN when the lastMentionedTime on the report is later than the lastReadTime. This is very similar to the logic for marking a report as unread in the LHN.

The details of the implementation are described in the doc here.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f14c3b5869ba2233
  • Upwork Job ID: 1651376753746407424
  • Last Price Increase: 2023-04-27
@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 24, 2023
@puneetlath puneetlath self-assigned this Apr 24, 2023
@MelvinBot
Copy link

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 24, 2023
@puneetlath puneetlath changed the title Render green dot in LHN when user is mentioned Show green dot in LHN when user is mentioned Apr 24, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 26, 2023
@puneetlath puneetlath added the Internal Requires API changes or must be handled by Expensify staff label Apr 27, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01f14c3b5869ba2233

@MelvinBot
Copy link

Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.

@puneetlath
Copy link
Contributor Author

@0xmiroslav got auto-assigned by puller bear to review the PR, so assigning them here too.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 9, 2023
@melvin-bot melvin-bot bot changed the title Show green dot in LHN when user is mentioned [HOLD for payment 2023-05-16] Show green dot in LHN when user is mentioned May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter n/a
  • Contributor that fixed the issue n/a
  • Contributor+ that helped on the issue and/or PR @0xmiroslav

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@puneetlath
Copy link
Contributor Author

Contract sent to @0xmiroslav.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2023
@puneetlath
Copy link
Contributor Author

Paid! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

3 participants