Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-22] Add mentions auto-completion #17890

Closed
puneetlath opened this issue Apr 24, 2023 · 14 comments
Closed

[HOLD for payment 2023-05-22] Add mentions auto-completion #17890

puneetlath opened this issue Apr 24, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@puneetlath
Copy link
Contributor

As part of the mentions project, we will be adding auto-completion for mentions by using the @ symbol. We should break this up into at least two PRs:

  1. Adding the generic AutoCompleteSuggestions component and refactoring the existing EmojiSuggestions to use the new AutoCompleteSuggestions component
  2. Adding MentionAutoSuggestions which will also use the AutoCompleteSuggestions component

The details of the implementation are described in the doc here.

@puneetlath puneetlath added Daily KSv2 NewFeature Something to build that is a new item. labels Apr 24, 2023
@puneetlath puneetlath self-assigned this Apr 24, 2023
@MelvinBot
Copy link

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 24, 2023
@szebniok
Copy link
Contributor

Hey, I'll be working on this.

@MelvinBot

This comment was marked as off-topic.

@puneetlath
Copy link
Contributor Author

PR 1 is up!

@puneetlath
Copy link
Contributor Author

Assigning @0xmiroslav as C+

@melvin-bot melvin-bot bot added the Overdue label May 4, 2023
@szebniok szebniok mentioned this issue May 5, 2023
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 5, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 15, 2023
@melvin-bot melvin-bot bot changed the title Add mentions auto-completion [HOLD for payment 2023-05-22] Add mentions auto-completion May 15, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@puneetlath
Copy link
Contributor Author

@0xmiroslav sent you an offer in Upwork: https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/24557708

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 21, 2023
@puneetlath
Copy link
Contributor Author

All paid. Thanks again everyone!

@0xmiros
Copy link
Contributor

0xmiros commented May 22, 2023

@puneetlath sorry, this issue is linked to 2 PRs: #18024, #18469

@puneetlath
Copy link
Contributor Author

Ah whoops. Well it's already paid!

@0xmiros
Copy link
Contributor

0xmiros commented May 22, 2023

#18024 - this one too?

@puneetlath puneetlath reopened this May 22, 2023
@puneetlath
Copy link
Contributor Author

puneetlath commented May 22, 2023

Ahhh sorry. I see the mistake. Sent you another contract. (https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/24664071)

@puneetlath
Copy link
Contributor Author

Ok all paid for real now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

4 participants