[HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled

[cristipaval]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Begin sign in with an account with 2fa enabled
2. Click in the magic link
3. Head back to the initial tab
4. Insert the 2fa code

Expected Result:

The user should get straight into the App

Actual Result:

The user sees a never-ending loading spinner.

Workaround:

Refresh the tab where the user inerted the 2fa code.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @cristipaval
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682429757156649

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[tienifr]

I can't reproduce it on my branch (before the revert). @cristipaval Can you give more context?

Cc @Santhosh-Sellavel @luacmartins Can you confirm whether you can reproduce this one?

Screencast.from.26-04-2023.23.40.00.webm

[Santhosh-Sellavel]

@tienifr You should try with TFA Enabled account

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Fix: No notification on web if window is not active" #17970

If no regressions arise, payment will be issued on 2023-05-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cristipaval] The PR that introduced the bug has been identified. Link to the PR: here
• [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: here
• [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: here
• [@cristipaval] Determine if we should create a regression test for this bug.
• [@cristipaval] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[maddylewis]

@cristipaval - when you have a sec, will you fill out your portion of the BZ checklist?

then, before i process payment, i wanted to confirm that @Santhosh-Sellavel and @tienifr are both receiving $1000 for this one.

[cristipaval]

Done.

There is already an open issue for adding regression steps around automatic authentication in NewDot.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[maddylewis]

thanks! i will get offers sent over before EOD - (@Santhosh-Sellavel and @tienifr both receiving $1000)

[Santhosh-Sellavel]

@maddylewis Sorry for the delay. No payment is due here for Contributor/C+. As this was a regression from the other issue #17242. We can close the jobs & this issue as all completed here!

[cristipaval]

Right, no payments needed for this one. Thanks @Santhosh-Sellavel and @maddylewis !