Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Animations into NewDot #18023

Closed
grgia opened this issue Apr 26, 2023 · 12 comments
Closed

Add Animations into NewDot #18023

grgia opened this issue Apr 26, 2023 · 12 comments
Assignees
@shawnborton @grgia @flaviadefaria @0xmiros
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@grgia
Copy link
Contributor

grgia commented Apr 26, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Placement issue for tracking some of the small animation additions. Sign-in-page, coin loading, etc.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012f5aac598fee1253
  • Upwork Job ID: 1651198554592088064
  • Last Price Increase: 2023-04-26
@grgia grgia added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Design labels Apr 26, 2023
@grgia grgia self-assigned this Apr 26, 2023
@MelvinBot
Copy link

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~012f5aac598fee1253

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@grgia grgia mentioned this issue Apr 26, 2023
Merged
54 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 26, 2023
@grgia
Copy link
Contributor Author

grgia commented May 2, 2023

Closing in favor of individual issues

@grgia grgia closed this as completed May 2, 2023
@0xmiros
Copy link
Contributor

0xmiros commented May 2, 2023

@grgia can you please add BZ member for me?

@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label May 2, 2023
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 2, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@grgia
Copy link
Contributor Author

grgia commented May 2, 2023

@flaviadefaria could you handle the Internal PR review payment for @0xmiroslav

@grgia grgia reopened this May 2, 2023
@flaviadefaria
Copy link
Contributor

Sure @grgia! I haven't handled one of these before, how much do we pay for Internal PR reviews?

@0xmiros
Copy link
Contributor

0xmiros commented May 2, 2023

how much do we pay for Internal PR reviews?

it's flatten as 1k

@flaviadefaria
Copy link
Contributor

Contract sent!

@flaviadefaria
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnborton shawnborton

@grgia grgia

@flaviadefaria flaviadefaria

@0xmiros 0xmiros

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Design Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shawnborton @MelvinBot @grgia @flaviadefaria @0xmiros