Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18163

Closed
melvin-bot bot opened this issue Apr 28, 2023 · 4 comments
Closed

[Snyk] Security upgrade electron from 22.3.6 to 22.3.7 #18163

melvin-bot bot opened this issue Apr 28, 2023 · 4 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Apr 28, 2023

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Access of Resource Using Incompatible Type ('Type Confusion')
SNYK-JS-ELECTRON-5425841
No Mature
high severity Integer Overflow or Wraparound
SNYK-JS-ELECTRON-5462056
No Mature

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e86919bfd8e54a2d
  • Upwork Job ID: 1652046541960138752
  • Last Price Increase: 2023-04-28
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Apr 28, 2023
@MelvinBot
Copy link

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01e86919bfd8e54a2d

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 28, 2023
@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@rushatgabhane
Copy link
Member

rushatgabhane commented May 5, 2023

Someone please close this because #18193 fixed this issue.
cc: @michaelhaxhiu :)

@michaelhaxhiu michaelhaxhiu self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants