Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Manage members - After clicking the "Invite" button, 403 error appears in console #18335

Closed
2 of 6 tasks
kbecciv opened this issue May 3, 2023 · 14 comments
Closed
2 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Go Workspace -> Manage Members
  3. Click "Invite"

Expected Result:

Nothing should happen.

Actual Result:

After clicking the "Invite" button, 403 error appears in console.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041115_Recording__553.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f118a4014c31102
  • Upwork Job ID: 1653815302934618112
  • Last Price Increase: 2023-05-03
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

@kbecciv
Copy link
Author

kbecciv commented May 3, 2023

Issue is not reproductible in Production.

Recording.2642.mp4

@marcaaron
Copy link
Contributor

Hmm... looks like we are trying to load a default avatar that doesn't exist:

https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_0.png

They should start at 1 so the 0 is suspect. I wonder if we are sending this via the backend?

@marcaaron
Copy link
Contributor

Yep we definitely are...

2023-05-03_07-34-13

@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label May 3, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~018f118a4014c31102

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

@marcaaron
Copy link
Contributor

Ok so this is a deploy blocker for Web but not App. I think we can remove the label. cc @grgia as it looks related to https://github.com/Expensify/Web-Expensify/pull/37178

@marcaaron marcaaron added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 3, 2023
@francoisl francoisl self-assigned this May 3, 2023
@francoisl
Copy link
Contributor

We identified the issue, working on a fix now.

@marcaaron
Copy link
Contributor

Thanks @francoisl !

@francoisl francoisl added the Reviewing Has a PR in review label May 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

@puneetlath, @francoisl Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@francoisl
Copy link
Contributor

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants