Workspace - Created Workspace looks greyed out when user go offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Go to settings > Create a Workspace
3. Go offline

Expected Result:

Created Workspace should not be greyed out when user go offline

Actual Result:

Created Workspace looks greyed out when user go offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041417_Screen_Recording_20230503_174118_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0149848cd4d85e1151
• Upwork Job ID: 1653848581666627584
• Last Price Increase: 2023-05-03

[kbecciv]

Issue is not reproductible in production.

Screen.Recording.20230503.181950.Chrome.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

I think this is also related to the Pusher stuff @iwiznia is looking at. The workspace ends up with a pendingAction: 'add' even though the workspace is created successfully.

requestID: 7c1a51c6eb89bc6f-SJC

[marcaaron]

Though, actually, I was testing against production API and staging version of the App - so maybe unrelated.

[marcaaron]

@arosiclair I see you're busy with another urgent situation so I'm gonna grab this from ya.

[marcaaron]

Edit: Sorry meant to post this on this issue

[marcaaron]

This one is pretty weird. I think the way the workspace clears the pendingAction: 'add' is via the successData here:

App/src/libs/actions/Policy.js

Lines 958 to 963 in 40248ae

	successData: [
	{
	onyxMethod: CONST.ONYX.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
	value: {pendingAction: null},
	},

But because the Pusher issue is causing a jsonCode: 413 to be returned the successData doesn't get applied and things end up stuck in a pending state 🤔

[marcaaron]

I'm gonna remove the blocker here because I think this is related to the web deploy and shouldn't affect NewDot when using the production web API.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0149848cd4d85e1151

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[iwiznia]

I think this is also related to the Pusher stuff @iwiznia is looking at. The workspace ends up with a pendingAction: 'add' even though the workspace is created successfully.

If the event did not succeed then maybe, but if it did I don't think it is related.

[marcaaron]

This is not happening anymore so whatever we did fixed it.