Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - URL Copy menu exceeds the width of 375px #18349

Closed
1 of 6 tasks
kbecciv opened this issue May 3, 2023 · 6 comments
Closed
1 of 6 tasks

mWeb - Chat - URL Copy menu exceeds the width of 375px #18349

kbecciv opened this issue May 3, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #17640

Action Performed:

  1. Login any account
  2. Go to any chat with link among message
  3. Right click any link
  4. Inspect the width of menu

Expected Result:

Menu should not exceed the width of 375px.

Actual Result:

URL Copy menu exceeds the width of 375px on mWeb. In my case 393 px

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041423_video_05.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv kbecciv changed the title mWeb - URL Copy menu exceeds the width of 375px mWeb - Chat - URL Copy menu exceeds the width of 375px May 3, 2023
@mountiny
Copy link
Contributor

mountiny commented May 4, 2023

@allroundexperts @sobitneupane This seems as a regression/ not covered case from your PR

@allroundexperts
Copy link
Contributor

@mountiny What's the expected behaviour here? Do we not want to show the full screen width menu?

@sobitneupane
Copy link
Contributor

@mountiny I don't think this is regression. It is an expected output. We might have missed to mention in QA steps in the PR that, maxWidth of 375px is expected only on large screen device.

@mountiny
Copy link
Contributor

mountiny commented May 4, 2023

Gotcha yeah that makes sense, havent properly read the issue sorry. Thanks for chiming in!

@mountiny mountiny closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

6 participants