Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - "Settled up $XX elsewhere" instead of "Settled up $XX" for paid IOU #18362

Closed
6 tasks done
kbecciv opened this issue May 3, 2023 · 8 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented May 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #17090

Action Performed:

  1. As userA, FAB > Request Money to userB.
  2. As userB Settle up the request

Expected Result:

Report action should be received as "Settled up $XX."

Actual Result:

Report action is received as "Settled up $XX elsewhere"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041603_video_97-1__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kadiealexander
Copy link
Contributor

kadiealexander commented May 4, 2023

@luacmartins, @trjExpensify, @JmillsExpensify, @Julesssss I just wanted to check if this is supposed to be changed, as the design doc seems to keep the "settled up $xx elsewhere" messaging.

image

Thanks in advance for your advice!

@luacmartins
Copy link
Contributor

Thanks for checking @kadiealexander! We're still leaving the payment method in the message. That means that we should still see elsewhere and via Paypal.me. Closing this issue.

@luacmartins
Copy link
Contributor

@kbecciv do we need to update any regression tests to reflect my comment above?

@kbecciv
Copy link
Author

kbecciv commented May 5, 2023

Hello @luacmartins Please submit a "QA - Add/Update test to TestRail" ticket if you think we need to add specific validation go forward. We will cross check it

@luacmartins
Copy link
Contributor

@kbecciv only if we have a specific test case that validates the uppercase message. Otherwise no need to add one for it.

@kbecciv
Copy link
Author

kbecciv commented May 8, 2023

no, we don't have step for it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants