-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU - "Settled up $XX elsewhere" instead of "Settled up $XX" for paid IOU #18362
Comments
Triggered auto assignment to @kadiealexander ( |
Bug0 Triage Checklist (Main S/O)
|
@luacmartins, @trjExpensify, @JmillsExpensify, @Julesssss I just wanted to check if this is supposed to be changed, as the design doc seems to keep the "settled up $xx elsewhere" messaging. Thanks in advance for your advice! |
Thanks for checking @kadiealexander! We're still leaving the payment method in the message. That means that we should still see |
@kbecciv do we need to update any regression tests to reflect my comment above? |
Hello @luacmartins Please submit a "QA - Add/Update test to TestRail" ticket if you think we need to add specific validation go forward. We will cross check it |
@kbecciv only if we have a specific test case that validates the uppercase message. Otherwise no need to add one for it. |
no, we don't have step for it. Thank you |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #17090
Action Performed:
Expected Result:
Report action should be received as "Settled up $XX."
Actual Result:
Report action is received as "Settled up $XX elsewhere"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.9.14
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6041603_video_97-1__1_.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: