[$1000] Chat - Context Menu - User can move emotion reactions row

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #18365

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login to ND.
3. Open any chat with a history of messages.
4. Right click on any message that is close to the header.
5. Click and drag on the context menu, specifically the quick emoji reactions row and ensure that the window does not move.

Expected Result:

Emoji reactions row and window does not move.

Actual Result:

User can move emotion reactions row.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.11.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6045148_Recording__574.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ea82eb69ee3a04ea
• Upwork Job ID: 1657006167426883584
• Last Price Increase: 2023-05-12

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bfitzexpensify]

I am unable to reproduce:

2023-05-09_14-19-50.mp4

@kbecciv are you still able to reproduce this?

[therealsujitk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The reactions row (and other contents) in the context menu modal is drag-able even though it has the #no-drag-area id and shouldn't be drag-able.

What is the root cause of that problem?

The property -webkit-app-region in the code below doesn't prevent the user from dragging components, it only specifies that the region cannot be used to drag the window.

App/web/index.html

Lines 37 to 42 in d516b63

	#drag-area {
	-webkit-app-region: drag;
	}
	#no-drag-area {
	-webkit-app-region: no-drag;
	}

What changes do you think we should make in order to solve the problem?

To solve this problem we can use the property -webkit-user-drag. After this the content will still be drag-able if the text is selected first, to prevent this we can use the property user-select.

#no-drag-area {
    -webkit-app-region: no-drag;
    -webkit-user-drag: none;
    user-select: none;
}

What alternative solutions did you explore? (Optional)

• An alternative solution would be to call the preventDefault() function on the mouseDown event on the modal.

[therealsujitk]

@bfitzexpensify you can also try selecting text in the context menu to reproduce this. I believe the reaction bar is being selected somehow after which it becomes drag-able (explained in my proposal).

Screencast.from.09-05-23.10.18.32.PM.IST.webm

[huzaifa-99]

@therealsujitk i think we could also apply

 -webkit-user-drag: none;
 user-select: none;

to the emoji row directly as it makes everything inside the modal "non-dragable"

[therealsujitk]

@huzaifa-99 sorry I didn't get you. I applied it to anything with the id #no-drag-area so this fixes other components that have similar issues, consequently these properties also apply to the components descendants that includes the reaction row as well as the text below it.

[huzaifa-99]

I was actually suggesting to apply the styles to the emoji row only, but maybe thats not desired as you mentioned other areas might have those issues.

[bfitzexpensify]

Yep, after trying this a bunch, I was eventually able to reproduce.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ea82eb69ee3a04ea

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @thienlnam (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

I don't think this is a bug or something that we should be concerned about. Anything that is selectable is dragable.

@thienlnam @bfitzexpensify Can we close this?

[bfitzexpensify]

I think I agree, it doesn't seem like a significant issue. Happy to close if you are @thienlnam

[bfitzexpensify]

Let's close this out