Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] Secure NewDot Logins - Re-keying personal details & policy member Onyx data #19247

Closed
2 of 3 tasks
Beamanator opened this issue May 19, 2023 · 19 comments
Closed
2 of 3 tasks
Assignees
Labels
NewFeature Something to build that is a new item. Weekly KSv2

Comments

@Beamanator
Copy link
Contributor

Beamanator commented May 19, 2023

Detailed doc section

We want to get a small but key chunk of the "Secure NewDot Logins" reviewed and start implementation before some upcoming conferences. As such, we've added a Re-keying personal details & policy member Onyx data section to the design doc.

We created this board to keep track of issues for this project: https://github.com/orgs/Expensify/projects/36/views/1

  • Once this section goes through some reviews and we get close to implementation we'll start adding issues.

I'm creating this issue in order to get doc reviews on the "Re-keying personal details & policy member Onyx data" detailed design.

Implementation issues

@Beamanator Beamanator added Weekly KSv2 NewFeature Something to build that is a new item. labels May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

@Beamanator Beamanator changed the title Tracking issue: Secure NewDot Logins - Re-keying personal details & policy member Onyx data [Tracking issue] Secure NewDot Logins - Re-keying personal details & policy member Onyx data May 19, 2023
@Beamanator Beamanator added the DesignDocReview Autoassigner for design doc reviews label May 19, 2023
@melvin-bot

This comment was marked as outdated.

@melvin-bot melvin-bot bot removed the DesignDocReview Autoassigner for design doc reviews label May 19, 2023
@Beamanator Beamanator added the DesignDocReview Autoassigner for design doc reviews label May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

👋 Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Please, treat this as a priority. Review this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 pannel or follow these instructions.


@melvin-bot melvin-bot bot removed the DesignDocReview Autoassigner for design doc reviews label May 19, 2023
@greg-schroeder
Copy link
Contributor

I have read and reviewed this Design Doc!

2 similar comments
@tgolen
Copy link
Contributor

tgolen commented May 23, 2023

I have read and reviewed this Design Doc!

@flodnv
Copy link
Contributor

flodnv commented May 23, 2023

I have read and reviewed this Design Doc!

@isabelastisser
Copy link
Contributor

I have read and reviewed this Design Doc!

1 similar comment
@ghost
Copy link

ghost commented May 26, 2023

I have read and reviewed this Design Doc!

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@shawnborton
Copy link
Contributor

I have read and reviewed this Design Doc!

@puneetlath
Copy link
Contributor

Making good progress. Auth changes are done. Web changes are close. Once those are done, Callstack will be unblocked from starting to update the client to use the new Onyx object.

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@LLPeckham
Copy link
Contributor

I have read and reviewed this Design Doc!

@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2023
@puneetlath
Copy link
Contributor

We're very actively implementing this. We've done the Auth and Web changes and are now working on the front-end changes.

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@Beamanator
Copy link
Contributor Author

Finally merged the App changes last Thursday! Working on getting all the bug fixes worked out :D

@Beamanator
Copy link
Contributor Author

Re-keying efforts are going well! Changes have been live in the app and seem to be working well for SNH - cleanup efforts are underway but we're mainly holding the PRs till after SNH so we don't break anything 🙏

@melvin-bot melvin-bot bot removed the Overdue label Jun 27, 2023
@robertjchen
Copy link
Contributor

I have read and reviewed this Design Doc!

@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2023
@puneetlath
Copy link
Contributor

Almost done!

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2023
@Beamanator
Copy link
Contributor Author

The re-key is basically done, we're just working on cleaning out a few remaining emails from Onyx - this is bring tracked in the main issue https://github.com/Expensify/Expensify/issues/280523

So closing this one!

@melvin-bot melvin-bot bot removed the Overdue label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants