[$1000] Assignee- Error appears when adding phone number account as Assignee

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19335

Action Performed:

1. Login with any Expensifail account
2. Verify that this account has at least one contact that is an account created by phone number
3. Go to FAB -> Assign Task -> Enter a title and description and navigate to next page
4. Click on the "Assignee" and enter the correct phone number
5. Verify that the account with phone number is added as assignee and no error appears

Expected Result:

Error should not appeared when adding phone number account as Assignee.

Actual Result:

Error appears when adding phone number account as Assignee

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/ec7888efd5da4a5ab53d25c7ac2435c076a953e6a5b3b7260677f32ae9b50a8c

https://platform.applause.com/services/links/v1/external/4f84d421bc5f87d23cd8f1d82bc6c49b2caaa6215541f7497a2e25ff24352cf0

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01388ffc6e533f7db8
• Upwork Job ID: 1661092904985145344
• Last Price Increase: 2023-05-23

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[conorpendergrast]

I reproduced this, using my own phone number. Interestingly, it didn't work either when I selected the SMS-based user either

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01388ffc6e533f7db8

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

[conorpendergrast]

@yuwenmemon Can you give a quick look and see if you think this should be internal or external? I think it should be internal, but have been wrong before

[yuwenmemon]

It looks external. Also, cc @cdanwards since this seems to come from your pr here: #17992

[conorpendergrast]

I live to be wrong. Thanks, I'll switch it to External

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @yuwenmemon is eligible for the External assigner, not assigning anyone new.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee- Error appears when adding phone number account as Assignee

What is the root cause of that problem?

The error is come from those LOC

App/src/pages/tasks/NewTaskPage.js

Lines 79 to 83 in d70b746

	const assigneeDetails = lodashGet(props.personalDetails, props.task.assignee);
	if (!assigneeDetails) {
	setSubmitError(true);
	return setErrorMessage(props.translate('newTaskPage.assigneeError'));
	}

Whenever we assign an assignee, we will look into props.personalDetails to get assignee details. If we haven't chat with this assignee before, we won't find it in props.personalDetails store.

We will fill the assignee details later when openReport API is finished here in the action to setAssigneeValue

Then the error will be disappear.

What changes do you think we should make in order to solve the problem?

I think we can optimistic add assignee details to personalDetails in Onyx. So we can have assignee data to show in the Task page. It also help to assign task for a new assignee when offline.

[dukenv0307]

It's duplicate with issue #19203 and out of scope of PR #19335

[conorpendergrast]

Looks like it's also duplicate of this issue #18649. Closing this out as a result!