Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD App/issues/19534] Cleanup: Remove useEmojiReactions param from NewDot #19535

Closed
1 task
Tracked by #16506
tgolen opened this issue May 24, 2023 · 12 comments
Closed
1 task
Tracked by #16506

[HOLD App/issues/19534] Cleanup: Remove useEmojiReactions param from NewDot #19535

tgolen opened this issue May 24, 2023 · 12 comments
Assignees
@stitesExpensify
Labels
Engineering Monthly KSv2 Task

Comments

@tgolen
Copy link
Contributor

tgolen commented May 24, 2023

As the last part of cleanup for #16506 useEmojiReactions parameter can be removed since nothing is referencing it in the API anymore.

  1. Search the code for useEmojiReactions
  2. Remove the two instances where it is used in lib/actions/Report.js for adding and removing emoji
@tgolen tgolen self-assigned this May 24, 2023
@tgolen tgolen mentioned this issue May 24, 2023
Closed
12 tasks
@MariaHCD MariaHCD mentioned this issue May 26, 2023
Merged
57 tasks
@tgolen tgolen mentioned this issue May 30, 2023
Draft
56 tasks
@tgolen tgolen assigned stitesExpensify and unassigned tgolen May 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 7, 2023
@stitesExpensify
Copy link
Contributor

holding

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 28, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 23, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2023
@stitesExpensify stitesExpensify added Monthly KSv2 and removed Weekly KSv2 labels Sep 1, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 1, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@stitesExpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2023
@stitesExpensify
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2024
@stitesExpensify
Copy link
Contributor

Closing for now to focus on waves

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stitesExpensify stitesExpensify

Labels
Engineering Monthly KSv2 Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgolen @stitesExpensify