A Long workspace name is cut off in Details sidebar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on 'Profile' icon
2. Click on 'Workspace' link
3. Click on an existing workspace
4. Rename the workspace name with a long name to 55 to 60 characters
5. Close RHN
6. Open admin room of the corresponding workspace
7. Click on header
8. Verify Details sidebar is opened

Expected Result:

Workspace name shouldn't be cut off

Actual Result:

Workspace name is cut off

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-23.10.45.40.mp4

Expensify/Expensify Issue URL:
Issue reported by:
@Natnael-Guchima
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1684828146658919
View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

As noted in the slack thread i dont think this is a bug

[kavimuru]

I was able to reproduce with 58 characters. Should this be more than 60 characters @Natnael-Guchima?

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A Long workspace name is cut off in Details sidebar

What is the root cause of that problem?

We haven't set the width for the wrapper element of chat room subtitle text so the text won't be truncated with ellipse when it's too long

App/src/pages/ReportDetailsPage.js

Lines 162 to 168 in 0f33e2c

	<Pressable
	onPress={() => {
	Navigation.navigate(ROUTES.getWorkspaceInitialRoute(this.props.report.policyID));
	}}
	>
	{chatRoomSubtitleText}
	</Pressable>

What changes do you think we should make in order to solve the problem?

We need to set style props with styles.w100 to Pressable component so it will truncate the text the it reach maximum width

Results:

[Natnael-Guchima]

I was able to reproduce with 58 characters. Should this be more than 60 characters @Natnael-Guchima?

@kavimuru I don't think it has to be more than 60 characters. last time I checked I was able to reproduce this with 59 characters.

[dhairyasenjaliya]

looks like the affected PR is #19064

[kevinksullivan]

closing per the slack discussion.

[0xZaitsev]

#issuecomment-1636820736