[HOLD for payment 2023-06-29] [$1000] Strange UX when creating tasks in a DM

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. A creates a task in the group DM (A,B andC) and assigned it to B
2. Log in as C and there is no indicator it is assigned to B, either in the main chat or in the task thread. But C has access to the task thread, but there's no obvious way for the other participants to know C is included.
3. B initially saw just the checkbox without the Task title next to it. When he clicked into that thread and then back to DM with A, then only able to see the title
4. As user C click the "Mark as Done" button in the task thread.

Expected Result:

Able mark as done

Actual Result:

Tt flashes complete and switches back to the button

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-23.at.9.42.07.AM.mov

Recording.763.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684861533207629

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0faa4b5ac73262e
• Upwork Job ID: 1663179954798112768
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sonialiap]

Adding external label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0faa4b5ac73262e
https://www.upwork.com/jobs/~01c82524e36b0d22ed

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @joelbettner (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Strange UX when creating tasks in a DM

What is the root cause of that problem?

There are 3 problems according to steps above:

1. Log in as C and there is no indicator it is assigned to B, either in the main chat or in the task thread

It's fixed in main chat by this PR #19990
The only problem is in the Task thread, it's showing empty for assignee

I found that, because the props.report.managerEmail is empty in C and B side. So it shows nothing in the Task thread

Screenshot of prop.report from C side

2. As user C click the "Mark as Done" button in the task thread. It flashes complete and switches back to the button

When display "Mark as Done" button, we haven't checked who can see that button yet. So whoever can access the taskReport, they can see that button.

App/src/components/TaskHeader.js

Lines 78 to 98 in 0c44fed

	<View style={[styles.flexRow]}>
	{isCompleted ? (
	<>
	<Text>{props.translate('task.completed')}</Text>
	<View style={styles.moneyRequestHeaderCheckmark}>
	<Icon
	src={Expensicons.Checkmark}
	fill={themeColors.iconSuccessFill}
	/>
	</View>
	</>
	) : (
	<Button
	success
	isDisabled={TaskUtils.isTaskCanceled(props.report)}
	medium
	text={props.translate('newTaskPage.markAsDone')}
	onPress={() => TaskUtils.completeTask(props.report.reportID, parentReportID, title)}
	/>
	)}
	</View>

3. B initially saw just the checkbox without the Task title next to it. When he clicked into that thread and then back to DM with A, then only able to see the title

It's fixed somewhere

What changes do you think we should make in order to solve the problem?

1. Log in as C and there is no indicator it is assigned to B, either in the main chat or in the task thread

To solve this problem in Task thread, we can either:

• Option 1: Replicate what we did for TaskPreview when getting the assigneeEmail. That means, we can get it in either report.managerEmail or taskReportAction.childManagerEmail. To retrieve the taskReportAction, we can use the props.report.parentReportID and props.report.parentReportActionIDto find in the reportActions collection cached in ReportActionUtils

• Option 2: Wait/update BE to return report.managerEmail for both B & C in this case.

2. As user C click the "Mark as Done" button in the task thread. It flashes complete and switches back to the button

We should only show this button if the current user is either taskAssignee or actorEmail/ownerEmail of a task. We can get the taskAssigneeEmail by above option, and task ownerEmail in the props.report

We also only enable checkbox in the chatReport if the current user is either taskAssignee or actorEmail/ownerEmail too. So "C" in this case won't neither check/uncheck task nor click "Mark as Done" button.
Other place is "Mark as incomplete", we need to add above condition to this button too.

[sonialiap]

@mollfpr what do you think of this proposal?

[mollfpr]

Reviewing now!

[sonialiap]

@mollfpr How did the review go? 😄

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

@sonialiap I still need more time on this. I'll get back to you in the morning 🙏

[mollfpr]

Log in as C and there is no indicator it is assigned to B, either in the main chat or in the task thread

@hoangzinh Now we have the assignee email in the main report but still need the assignee in the thread on the account C.

B initially saw just the checkbox without the Task title next to it. When he clicked into that thread and then back to DM with A, then only able to see the title

@hoangzinh Could you verify if this still reproduces? I see both the task title and the assignee.

When display "Mark as Done" button, we haven't checked who can see that button yet. So whoever can access the taskReport, they can see that button.

@hoangzinh How are we going to check the button? Is this also apply to disabling or hiding the checkbox as well?

[melvin-bot]

📣 @hoangzinh You have been assigned to this job by @joelbettner!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hoangzinh]

@mollfpr @joelbettner PR is ready #20689. Please help me review it. Thanks ❤️

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-06-12 15:06:40 Z
• when the PR got merged: 2023-06-18 22:31:51 UTC
• days elapsed: 5

On to the next one 🚀

[melvin-bot]

@hoangzinh, @joelbettner, @sonialiap, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

Melvin, PR is merged. Waiting to be deployed to Staging then Production

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix empty assignee in TaskHeader and update permission to mark Task complete/incomplete/cancel in Task report #20689

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

#17940
#18806

[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/17940/files#r1246167109
#18806 (comment)

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Account A creates a task in the group DM (account A, account B, and account C) and assigns it to account B
2. Log in as account C, navigate to the task report above
3. Verify that account C can see account B displayName in the TaskHeader as an assignee.
4. Verify that account C can not click on the "Mark as done" button and account C can not see the three-dot in the top right
5. Log in as account B, navigate to the task report above
6. Verify that account B can see account B displayName in the TaskHeader as an assignee
7. Verify that account B can click on the "Mark as done" button and can see three-dot in the top right
8. log in as account A
9. Repeat 6->7
10. 👍 or 👎

[sonialiap]

@hoangzinh offer sent for fix
@mollfpr offer sent for review

PR submitted on Jun 13 5:57 PM (Tuesday)
PR merged on Jun 19 12:31 AM (Monday)
By my count that's over 3 days (merge by Friday 5:57 PM would have been 3 days), so no bonus for this issue.

[hoangzinh]

Accepted. Thanks @sonialiap

[sonialiap]

Both have been paid ✅

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.