[$1000] [HOLD for payment 2023-06-09] Signing in with magic link results in incorrect two factor authentication code

[NikkiWines]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Open newDot on your mobile device
Enter the login for an account with 2FA enabled
Get sent a magic code
Tap the magic link in your SMS or email inbox

Expected Result:

View should update and user should be prompted for their 2FA code

Actual Result:

User gets Incorrect Two Factor Authenticate code. Please try again error message

Workaround:

User can copy-paste or manually enter the code from their notification

Platforms:

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.18-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): nikkiwines@expensify.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL: N/A
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684946460798249

Screen_Recording_2023-05-25_at_23.40.11.mov

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015475622e806423d9
• Upwork Job ID: 1661869865818497024
• Last Price Increase: 2023-06-09

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[Natnael-Guchima]

I have reported a similar issue here #19606. It might need to be closed since the issue is being solved here.

[cristipaval]

I have reported a similar issue here #19606. It might need to be closed since the issue is being solved here.

You're right, they both have the same root. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.22-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix automatic authentication with magic link. #19637

If no regressions arise, payment will be issued on 2023-06-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[NikkiWines]

Oh, we need a BZ person on this to issue payment for this don't we - adding the External label so we can get this sorted

[melvin-bot]

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignees @NikkiWines and @cristipaval are eligible for the External assigner, not assigning anyone new.

[NikkiWines]

@NicMendonca we just need to pay @parasharrajat for reviewing this internal PR 🙇

[cristipaval]

@NicMendonca will pay this soon.

[NicMendonca]

@parasharrajat sent you the offer!

[parasharrajat]

@NicMendonca Thanks. Accepted it.

[NicMendonca]

Paid!! 🎉 🎉 🎉 🎉