Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] iOS - Add bank account - Not able to fill out the form "Personal Information" in offline #19869

Closed
1 of 6 tasks
lanitochka17 opened this issue May 30, 2023 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented May 30, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login to ND
  3. Navigate to the add bank account modal in Workspace settings
  4. Start and follow the flow for adding a fully verified bank account until the "Personal Information" step
  5. Disable the internet connection
  6. Verify you're able to fill out the form. Fill out all the fields

Expected Result:

User able to fill out the form. "Personal Information" in offline.

Actual Result:

User can not fill out the form "Personal Information" in offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.20.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

https://expensify.testrail.io/index.php?/tests/view/3479776

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/927c320a6ff1f43be7addb79dc3ef2ee95d71786d12ae038f25bf5e254cb30f5

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c56f5e44e92eb6a8
  • Upwork Job ID: 1663794483970064384
  • Last Price Increase: 2023-05-31
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 30, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@jliexpensify
Copy link
Contributor

Mobile issue swap with Kadie!

@kadiealexander
Copy link
Contributor

Able to reproduce!

RPReplay_Final1685513685.mov

@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label May 31, 2023
@melvin-bot melvin-bot bot changed the title iOS - Add bank account - Not able to fill out the form "Personal Information" in offline [$1000] iOS - Add bank account - Not able to fill out the form "Personal Information" in offline May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c56f5e44e92eb6a8

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Triggered auto assignment to @cead22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@priyeshshah11
Copy link
Contributor

@kadiealexander This looks intentional as per the code, doesn't look like a bug.

@kadiealexander
Copy link
Contributor

Oooh good find @priyeshshah11!!

@cead22 would you know if this is following the correct Offline Pattern? I wasn't able to find where we defined the offline pattern for adding a VBA and the Testrail test shows that it should be Pattern A but as @priyeshshah11 noted above, it seems we've coded it to Pattern D. I don't know enough about how VBA setups interact with the server to follow the flowchart correctly.

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

@cead22, @kadiealexander, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@bondydaa
Copy link
Contributor

bondydaa commented Jun 5, 2023

as noted here #19863 (comment) there are currently a few similar bugs all reported and seem to be the same so lets consolidate them into a single bug and get them all addressed.

@bondydaa
Copy link
Contributor

bondydaa commented Jun 5, 2023

closing in favor of #18990

@bondydaa bondydaa closed this as completed Jun 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants