Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Bill - First created bill description is not empty #20505

Closed
6 tasks done
kbecciv opened this issue Jun 9, 2023 · 5 comments
Closed
6 tasks done

Split Bill - First created bill description is not empty #20505

kbecciv opened this issue Jun 9, 2023 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20115

Action Performed:

  1. Create a split bill
  2. Add All necessary info and description.
  3. Create split bill.
  4. Create another split bill.
  5. Open the previously created bill.
  6. Description and currency is as expected.
  7. Create a split bill with empty description and also change the currency.
  8. Create a new split bill with some description.

Expected Result:

Open the first created split bill, description should be empty and currency should be the same that when created.

Actual Result:

Split bill description is not empty but currency is correct

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6085738_Recording__263.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@c3024
Copy link
Contributor

c3024 commented Jun 9, 2023

Third split bill description is empty and others have non-empty descriptions. What is the bug? Could you please explain?

@joekaufmanexpensify
Copy link
Contributor

I agree. i think this is expected behavior. In the other issue, the bug was that we were overwriting description in an existing IOU, when creating another one.

Here the bug report seems to be that we are not doing this. But that's not a bug. When a new bill split is created, we should not overwrite the description of an existing bill split.

@Julesssss mind sense checking my thinking here as you worked on the other issue? IMO, we should close this.

@Julesssss
Copy link
Contributor

Yeah, I'm also confused by this report. It seems to be working correctly to me (but @kbecciv are we missing something?)

I'm going to close it in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants