[$1000] Context menu hides on click of reveal message or hide message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. from userA , send any message to userB
2. from userB, mark that message as offensive
3. click on reveal message or hide message option

Expected Result:

Context menu should not hide on click of reveal message or hide message

Actual Result:

Context menu hides on click of reveal message or hide message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-05.at.7.37.54.PM.mov

Recording.928.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685974173855139
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0123ee093f8d7b9ffe
• Upwork Job ID: 1668727146272120832
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Context menu hides on click of reveal message or hide message

What is the root cause of that problem?

When clicking the Reveal button, the Blur function here will be triggered

App/src/components/Hoverable/index.js

Lines 109 to 119 in 82ce35f

	onBlur: (el) => {
	if (!this.wrapperView.contains(el.relatedTarget)) {
	this.setIsHovered(false);
	}
	if (_.isFunction(child.props.onBlur)) {
	child.props.onBlur(el);
	}
	},
	});
	}

so that we will set IsHovered is false

What changes do you think we should make in order to solve the problem?

We should prevent text input blur when the Reveal message is clicked like as Add reaction button here

App/src/components/Reactions/AddReactionBubble.js

Lines 75 to 76 in 82ce35f

	// Prevent text input blur when Add reaction is clicked
	onMouseDown={(e) => e.preventDefault()}

To do that in here

App/src/pages/home/report/ReportActionItem.js

Lines 271 to 275 in 82ce35f

	<Button
	small
	style={[styles.mt2, styles.alignSelfStart]}
	onPress={() => setIsHidden(!isHidden)}
	>

App/src/pages/home/report/ReportActionItem.js

Lines 301 to 305 in 82ce35f

	<Button
	small
	style={[styles.mt2, styles.alignSelfStart]}
	onPress={() => setIsHidden(!isHidden)}
	>

we should add

// Prevent text input blur when reveal message is clicked
onMouseDown={(e) => e.preventDefault()}

What alternative solutions did you explore? (Optional)

Result

My solution works well

Screen.Recording.2023-06-09.at.14.05.08.1.mp4

[bernhardoj]

Same root cause with this #16519

[melvin-bot]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

I'm able to reproduce but I noticed that the context menu will pop back up if I move my cursor up from the concierge message - I still think this is an issue as the user has to move the cursor around to get it to pop back up!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0123ee093f8d7b9ffe

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@dukenv0307 Thanks for the proposal. I'm afraid that we may not need to do anything here. This issue will be fixed once #20561 is merged.

[s77rt]

@bernhardoj Thanks!

[s77rt]

@adelekennedy Let's close this.

[getusha]

@adelekennedy I think we should handle the payment for both here?
According to this discussion a PR solving two issues will have the compensation handled on both issues.

https://expensify.slack.com/archives/C01GTK53T8Q/p1685711548218919

[s77rt]

@getusha I think that applies only to issues that have different root causes, it does not seem to be the case here.