Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLEANUP: Remove Flow Babel preset once the TS migration is done #20592

Closed
hayata-suenaga opened this issue Jun 12, 2023 · 17 comments
Closed

CLEANUP: Remove Flow Babel preset once the TS migration is done #20592

hayata-suenaga opened this issue Jun 12, 2023 · 17 comments
Assignees
@hayata-suenaga
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task Weekly KSv2

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Jun 12, 2023 •
edited
Loading

Remove @babel/preset-flow from babel.config.js once the TS migration is done.

from this line
and from this line

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019322a03e0bf0ef98
  • Upwork Job ID: 1668271821400170496
  • Last Price Increase: 2023-06-12
@hayata-suenaga hayata-suenaga added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019322a03e0bf0ef98

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@hayata-suenaga hayata-suenaga removed the Bug Something is broken. Auto assigns a BugZero manager. label Jun 12, 2023
@hayata-suenaga
Copy link
Contributor Author

this doesn't need C+ review un assigning @mananjadhav 🙇

@Expensify Expensify deleted a comment from melvin-bot bot Jun 12, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Jun 12, 2023
@hayata-suenaga
Copy link
Contributor Author

This is an internal cleanup. PLEASE DO NOT POST PROPOSALS

@hayata-suenaga hayata-suenaga changed the title Remove CLEANUP: Remove Flow Babel preset once the TS migration is done Jun 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 14, 2023
@hayata-suenaga hayata-suenaga removed the Daily KSv2 label Jun 14, 2023
@hayata-suenaga
Copy link
Contributor Author

this is monthly issue removing the daily label

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Jun 16, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@hayata-suenaga
Copy link
Contributor Author

the migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@hayata-suenaga
Copy link
Contributor Author

the migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 22, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@hayata-suenaga
Copy link
Contributor Author

TS migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
@hayata-suenaga
Copy link
Contributor Author

TS migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@hayata-suenaga
Copy link
Contributor Author

the typescript migration is still going

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@hayata-suenaga
Copy link
Contributor Author

TS migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Feb 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@hayata-suenaga
Copy link
Contributor Author

TS migration is still going on

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed Monthly KSv2 labels Apr 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@hayata-suenaga
Copy link
Contributor Author

changing this issue to weekly as the TS migration finishes in the App repo! 🚀

@hayata-suenaga hayata-suenaga mentioned this issue Apr 15, 2024
Closed
20 tasks
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

I think I can do it as part of this issue, wdyt @hayata-suenaga?

@hayata-suenaga hayata-suenaga mentioned this issue Apr 16, 2024
Closed
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Apr 16, 2024
@hayata-suenaga
Copy link
Contributor Author

@blazejkustra, I actually opened a PR for this.

However, the reason that we had this babel plugin for Flow was not that we used Flow before, but to do a workaround for a bug with React Native library. However, because this bug is quite old now, I'll try removing the plugin and see if that works.

@hayata-suenaga
Copy link
Contributor Author

seems like we cannot remove this babel config. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hayata-suenaga hayata-suenaga

Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Task Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mananjadhav @tjferriss @blazejkustra @hayata-suenaga