[HOLD for payment 2023-06-30] [$1000] Workspace - Error message when trying to access workspace created with different default contact method.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20406

Action Performed:

1. Login to NewDot under phone account
2. Add email as secondary login
3. Create a workspace
4. Change default contact from phone to email
5. Try to access settings of workspace from step 3

Expected Result:

User can open WS

Actual Result:

Error message when trying to access workspace created with different default contact method.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27-6

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_28.mp4

Recording.3101.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686598989456939

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143af88a3b986771d
• Upwork Job ID: 1670867972193251328
• Last Price Increase: 2023-06-19

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

Asking QA if this is indeeed not repro in production as I faced the same issue right now but also in prod

[kbecciv]

@mountiny
Issue is not reproductible in production

Recording.3104.mp4

[Beamanator]

@kbecciv just to be clear, if you sign out / in are you able to access the workspace?

I'm just guessing if you change the default contact method and THEN try to access the workspace you may not be able to, but if you log out / in you may be able to.

I'm going to try all your original steps in production to see if i get the error

[Beamanator]

Ya here's what I see on production, which leads me to believe this isn't a deploy blocker:

Screen.Recording.2023-06-14.at.5.04.05.PM.mov

[Natnael-Guchima]

@mountiny Yes, it is reproducible on production too. I reported this issue here when it was on staging.

2023-06-14.17.02.50.mp4

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Beamanator]

Getting a BugZero member here since we can go through the normal process with this one

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

An error message is displayed when trying to access a workspace created with a different default contact method.

What is the root cause of that problem?

The app checks the accessibility of the workspace with Policy.isPolicyOwner.

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 176 to 180 in 599f05a

	<FullPageNotFoundView
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}
	shouldShow={_.isEmpty(props.policy) || !Policy.isPolicyOwner(props.policy)}
	subtitleKey={_.isEmpty(props.policy) ? undefined : 'workspace.common.notAuthorized'}
	>

But after changing the default contact, the workspace policy owner is the previous contact and the session email is the current contact, so the check fails and an error is displayed.

What changes do you think we should make in order to solve the problem?

We should change the Policy.isPolicyOwner function to check the user's other contact.

The loginList Onyx data contains all the user's contacts, so we can check whether the policy owner is in the login list or not.

Add the following code to Policy.js.

let loginList;
Onyx.connect({
 key: ONYXKEYS.LOGIN_ LIST,
 callback: (val) = > (loginList = val),
});

And modify the isPolicyOwner function as follows.

function isPolicyOwner(policy) {
 return _.keys(loginList).includes(policy.owner);
}

What alternative solutions did you explore? (Optional)

None.

[michaelhaxhiu]

Seems like a valid bug to me. I will go with External but correct me if you think otherwise Alex :D

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0143af88a3b986771d

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

🎯 ⚡️ Woah @narefyev91 / @StevenKKC, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @StevenKKC got assigned: 2023-06-20 09:58:03 Z
• when the PR got merged: 2023-06-21 08:11:33 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix error message when access workspace created with different default contact method #21116

If no regressions arise, payment will be issued on 2023-06-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@michaelhaxhiu FYI it looks like @dhanashree-sawant actually reported this first in #21142

[melvin-bot]

@Beamanator, @michaelhaxhiu, @narefyev91, @StevenKKC Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

@StevenKKC can you please apply to the job? https://www.upwork.com/jobs/~0143af88a3b986771d

[StevenKKC]

@michaelhaxhiu I have applied to the job. Thanks.

[melvin-bot]

@Beamanator, @michaelhaxhiu, @narefyev91, @StevenKKC Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

Bump @michaelhaxhiu :D

[StevenKKC]

@michaelhaxhiu Could you please finish payment?

[StevenKKC]

Kindly bump @michaelhaxhiu

[michaelhaxhiu]

Damn. Sorry all. This slipped away from me as a loose end and I should've caught it sooner.

Payouts:

• $250 External issue reporter @dhanashree-sawant
• $1500 Contributor+ that helped on the issue and/or PR @StevenKKC

[michaelhaxhiu]

@StevenKKC can you let me know when you accept the offer?

[StevenKKC]

@michaelhaxhiu Accepted an offer. Thanks.