Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Back button brings to LHN while in loading state #20755

Closed
5 of 6 tasks
kbecciv opened this issue Jun 14, 2023 · 8 comments
Closed
5 of 6 tasks

Chat - Back button brings to LHN while in loading state #20755

kbecciv opened this issue Jun 14, 2023 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 14, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20344

Action Performed:

Prerequisites: throttle the internet connection

  1. Log in
  2. Open any chat
  3. Verify that styling of top header is unchanged and back button works as before (it do nothing)

Expected Result:

Back button should do nothing while loading

Actual Result:

Back button brings back to LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.27.4

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6092865_video_69__3_.mp4
Bug6092865_video_01__1_.mp4
Bug6092865_video_41__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 14, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@greg-schroeder
Copy link
Contributor

Reviewing

@greg-schroeder
Copy link
Contributor

@kbecciv Hmm - Is that true that pressing the back button is supposed to do nothing? I swear I've seen other issues where pressing the back button while offline is supposed to move you back a step, so I'm not sure on this one. 🤔

Can you offer more context on the expected behavior here? Perhaps there's a previous issue or something that shows the back button doing nothing as what we intended? Thanks!

@kbecciv
Copy link
Author

kbecciv commented Jun 15, 2023

@greg-schroeder Sorry for confusion, I have not been able to throttle this enough to get the loading state in the header and user is able to use back button.

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@greg-schroeder
Copy link
Contributor

I don't think I understand - @kbecciv - are you saying that what you showed in the video is not the behavior you're talking about? I'm just having a ton of trouble understanding what is wrong here.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 19, 2023
@greg-schroeder
Copy link
Contributor

Bump @kbecciv - can you clarify your last comment?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 21, 2023
@greg-schroeder
Copy link
Contributor

Closing per team discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants