[$1000] [HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Avatar is not loading when opening a 'share code' link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: account A & account B should be new accounts with no pre-existing chat history.

1. Open a tab where account A is signed in
2. Click on 'Profile' avatar > click on 'Share code' link > click on 'Copy URL to Clipboard button'
3. Open a tab where account B is signed in
4. Paste the URL to the search bar
5. Press Enter

Expected Result:

Avatar on the details page should load

Actual Result:

Avatar on the details page is not loading

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-06-18.17-23-12.copy.mp4

Recording.1017.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687098545598949

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b83ba6ed1e06ca4e
• Upwork Job ID: 1674016649320824832
• Last Price Increase: 2023-06-28

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal

I personally don't think this is a deploy blocker because this seems a lack from personalDetails refactor.

Please re-state the problem that we are trying to solve in this issue.

Avatar is not loading when opening a 'share code' link

What is the root cause of that problem?

We only compare the login from the share url with our local personalDetails accounts. If we couldn't find it, we added fallback icon, which showed in this issue.

App/src/pages/DetailsPage.js

Lines 94 to 109 in bee8fd3

	if (!details) {
	// TODO: these personal details aren't in my local test account but are in
	// my staging account, i wonder why!
	if (login === CONST.EMAIL.CONCIERGE) {
	details = {
	accountID: CONST.ACCOUNT_ID.CONCIERGE,
	login,
	displayName: 'Concierge',
	avatar: UserUtils.getDefaultAvatar(CONST.ACCOUNT_ID.CONCIERGE),
	};
	} else {
	details = {
	accountID: -1,
	login,
	displayName: login,
	avatar: UserUtils.getDefaultAvatar(),

What changes do you think we should make in order to solve the problem?

Since we already implemented new UserDetail page (/a route). We should also migrate our ShareUrl page to use it. Because right now, we still using the login instead of accountID.
So we should change the way we generate share url inside ShareCodePage to use accountID

// we should use accountID instead of login and use the route /a for personal detail
 const url = isReport ? `${CONST.NEW_EXPENSIFY_URL}r/${this.props.report.reportID}` : `${CONST.NEW_EXPENSIFY_URL}a/${this.props.session.accountID}`;

What alternative solutions did you explore? (Optional)

N/A

Result

Untitled.mov

[luacmartins]

PR is merged and being CP'ed right now. Removing the blocker label.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use new path for share url #21081

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use new path for share url #21081

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@deetergp] The PR that introduced the bug has been identified. Link to the PR:
• [@deetergp] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@deetergp] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@deetergp] Determine if we should create a regression test for this bug.
• [@deetergp] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b83ba6ed1e06ca4e

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[laurenreidexpensify]

Was adding external label to get Upwork job to pay the issue reporter, ignore C+ assignment

[laurenreidexpensify]

@Natnael-Guchima I have sent offer in Upwork for reporting bonus

[Natnael-Guchima]

Accepted the offer. Thanks @laurenreidexpensify

[hungvu193]

@laurenreidexpensify I think I'm eligible for payment for this issue, since my proposal was selected in the PR.
#21081

[deetergp]

I think the BugZero checklist here is moot since a refactor of the Personal Details data structure that didn't catch is what caused this issue. There's no real way to test for "Hey, when you change stuff, make sure you get all the cases." you can only do your best and then fix it quickly when you don't catch them all.

[laurenreidexpensify]

@hungvu193 that's fair - sent you an offer in upwork.
@Natnael-Guchima - payment has been issued

[hungvu193]

Thanks @laurenreidexpensify , accepted!

[Natnael-Guchima]

@hungvu193 that's fair - sent you an offer in upwork.
@Natnael-Guchima - payment has been issued

Received. Thanks 👍

[laurenreidexpensify]

@hungvu193 has been paid - closing