Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Group - Unknown broken contact is added to group when selecting contacts with only avatars #21086

Closed
5 of 6 tasks
lanitochka17 opened this issue Jun 19, 2023 · 13 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20951

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with applausetester+ihchat4@applause.expensifail.com
  3. Create a new group chat with multiple people with avatars (not default)
  4. Make sure that the icons in the initial group chat are the avatars

Expected Result:

The group with selected users created

Actual Result:

Unknown broken contact is added to the group. Sometimes I receive the error message
It happens with 2 accounts:
applausetester+ihchat4@applause.expensifail.com

applausetester+ihchat3@applause.expensifail.com

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.29.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6099240_2006

Bug6099240_Recording__5042__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 19, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 19, 2023

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

@Beamanator is this the expected behavior if users are unknown?

@Beamanator
Copy link
Contributor

Sorry @luacmartins @lanitochka17 it's really not clear to me what the exact problem is here - is it about the profile not showing any details at the end?

@lanitochka17
Copy link
Author

@Beamanator We chose the user "THE Maria Ajmera", but another person appeared in the group - Tom Rhys Jones.

Recording.2670.mp4

@luacmartins
Copy link
Contributor

I can't reproduce this.

@Beamanator
Copy link
Contributor

Same 🙃

@luacmartins
Copy link
Contributor

Ok, removing the deploy blocker label and adding Needs reproduction

@luacmartins luacmartins added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@luacmartins
Copy link
Contributor

Gonna un-assign myself until we can reproduce this issue.

@luacmartins luacmartins removed their assignment Jun 21, 2023
@Beamanator
Copy link
Contributor

I thinkkkkk this had to do with selecting options that didn't have logins - but that was changed to not be available in the "chat switcher" recently so i thinkkkkk this might not be reproducible anymore

@twisterdotcom
Copy link
Contributor

I cannot recreate this anymore:
image

Let's close and if anybody can reproduce, please comment and I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants