App crashes when you search any value on a fresh new public account

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new account which is on public domain
2. Click Search
3. Type in any value
4. The app crashes locally and throws error in staging

OptionsListUtils.js:753 Uncaught TypeError: Cannot read properties of undefined (reading 'searchText')
    at getOptions (OptionsListUtils.js:753:1)
    at Module.getSearchOptions (OptionsListUtils.js:832:1)
    at SearchPage.updateOptions (SearchPage.js:136:36)
    at later (debounce.js:17:1)

Expected Result:

Describe what you think should've happened

Results should show up

Actual Result:

Describe what actually happened

The App crashed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.29-8
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Internally
Slack conversation: https://expensify.slack.com/archives/C07J32337/p1687282960670579?thread_ts=1687190127.488249&cid=C07J32337

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @mountiny is eligible for the Engineering assigner, not assigning anyone new.

[lschurr]

Hiya @mountiny - need anything from BZ on this right now?

[mountiny]

Not yet, thank you 🙇

[mountiny]

I am now able to repro using staging web api but not with main web-E so I think this is related to what we send in the OpenApp call, investigating further. This is what OpenApp in staging returns:

[mountiny]

But main Web-E is returning:

 {
            "onyxMethod": "merge",
            "key": "personalDetails",
            "value": {
                "concierge@expensify.com": {
                    "accountID": 1,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/icons\/concierge_2022.png",
                    "displayName": "concierge@expensify.com",
                    "login": "concierge@expensify.com",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "America\/Los_Angeles"
                    },
                    "firstName": "",
                    "lastName": "",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": true
                },
                "test+21149a@blocker.com": {
                    "accountID": 328,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_9.png",
                    "displayName": "test+21149a@blocker.com",
                    "login": "test+21149a@blocker.com",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "America\/Los_Angeles"
                    },
                    "firstName": "",
                    "lastName": "",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": false,
                    "localCurrencyCode": "CZK"
                }
            }
        },
        {
            "onyxMethod": "merge",
            "key": "personalDetailsList",
            "value": {
                "1": {
                    "accountID": 1,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/icons\/concierge_2022.png",
                    "displayName": "concierge@expensify.com",
                    "login": "concierge@expensify.com",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "America\/Los_Angeles"
                    },
                    "firstName": "",
                    "lastName": "",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": true
                },
                "328": {
                    "accountID": 328,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_9.png",
                    "displayName": "test+21149a@blocker.com",
                    "login": "test+21149a@blocker.com",
                    "pronouns": "",
                    "timezone": {
                        "automatic": true,
                        "selected": "America\/Los_Angeles"
                    },
                    "firstName": "",
                    "lastName": "",
                    "payPalMeAddress": "",
                    "phoneNumber": "",
                    "validated": false,
                    "localCurrencyCode": "CZK"
                }
            }
        },

So the current staging api is not returning correct format and its missing the login in openApp personalDetailsList. Looking what PR added this back in Web-E

[mountiny]

This Web-E Pr should fix this https://github.com/Expensify/Web-Expensify/pull/37880

[mountiny]

It was actually this Auth PR which is now deployed so we can re-test in staging.

[mountiny]

Tested again in staging and seems to be fixed

No console errors, closing