Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] App navigates back to main chat if user clicks on invalid link in reply in thread and refreshes on 'Hmm its not here' page #21229

Closed
4 of 6 tasks
kbecciv opened this issue Jun 21, 2023 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app and login with user A
  2. Open user B chat
  3. Send any message
  4. Hover on message and click on reply in thread
  5. Send invalid expensify link eg: https://staging.new.expensify.com/r/49350451043078467
  6. From any other device, login with user B
  7. Open user A chat and click on latest message that has replies in thread
  8. Click on replies and click on invalid expensify link sent by user A
  9. Click on back to see that normally it navigates back to thread of reply in thread
  10. Again click on invalid link and reload the page
  11. Click on back to see that now it navigates back to main thread

Expected Result:

App should navigate back to thread of reply in thread if we click on any invalid expensify link in thread and press back

Actual Result:

App navigates to main thread rather then thread of reply in thread if we click on any invalid expensify link, reload and then press back

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

app.navigates.to.main.chat.after.invalid.link.reload.1.mp4
Recording.831.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686754122973049

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mallenexpensify mallenexpensify changed the title App navigates back to main chat if user clicks on invalid link in reply in thread and refreshes on 'Hmm its not here' page [HOLD #11768] App navigates back to main chat if user clicks on invalid link in reply in thread and refreshes on 'Hmm its not here' page Jun 22, 2023
@mallenexpensify
Copy link
Contributor

Putting on hold, commented here

@mountiny
Copy link
Contributor

I think this is expected. The information about where the UP button in the thread should go will be lost after the refresh as we only know the id of the invalid report.

I dont think this is a bug to work on, basically this is invalid report id which normal users dont get and the up button takes you to valid report.

Closing, feel free to reopen if you diagree

@mountiny mountiny moved this from Todo to Done in Navigation Refactor Follow-ups Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
No open projects
Development

No branches or pull requests

3 participants