[$1000] New task - Extra click/tap is required to change task assignee that you didn't have chat with

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20840

Action Performed:

1. Login to NEwDot
2. Create a task
3. Task chat is opened
4. Click header to change assignee
5. Select any member from the list that you didn't have chat with

Expected Result:

NEw assignee chosen

Actual Result:

New assignee is not changed, selected account just moved to Recents, need second click/tap to change assignee from Recents

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Bug6102067_video_38__3_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cd84d993daec02b5
• Upwork Job ID: 1673312870514081792
• Last Price Increase: 2023-08-18

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a console error when selecting a task assignee to a non-existing user. The issue only happens when editing the task assignee.

What is the root cause of that problem?

When we edit the task assignee, we will call both setAssigneeValue and editTaskAndNavigate.

App/src/pages/tasks/TaskAssigneeSelectorModal.js

Lines 165 to 172 in 6183609

	// Check to see if we're editing a task and if so, update the assignee
	if (props.route.params.reportID && props.task.report.reportID === props.route.params.reportID) {
	// There was an issue where sometimes a new assignee didn't have a DM thread
	// This would cause the app to crash, so we need to make sure we have a DM thread
	TaskUtils.setAssigneeValue(option.login, option.accountID, props.task.shareDestination, OptionsListUtils.isCurrentUser(option));
	// Pass through the selected assignee
	TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, props.session.accountID, {assignee: option.login, assigneeAccountID: option.accountID});
	}

In setAssigneeValue, we will call openReport that will optimistically create a new report for non-existing user

App/src/libs/actions/Task.js

Lines 485 to 498 in 6183609

	if (!isCurrentUser) {
	let newChat = {};
	const chat = ReportUtils.getChatByParticipants([newAssigneeAccountID]);
	if (!chat) {
	newChat = ReportUtils.buildOptimisticChatReport([newAssigneeAccountID]);
	}
	const reportID = chat ? chat.reportID : newChat.reportID;
	if (!shareDestination) {
	setShareDestinationValue(reportID);
	}
	Report.openReport(reportID, [assignee], newChat);
	}

Then in editTaskAndNavigate, we are trying to get the new created report reportID.

App/src/libs/actions/Task.js

Lines 315 to 316 in 6183609

	if (assigneeAccountID && assigneeAccountID !== report.managerID && assigneeAccountID !== ownerAccountID) {
	assigneeChatReportID = ReportUtils.getChatByParticipants([assigneeAccountID]).reportID;

The problem is, we are doing both setAssigneeValue and editTaskAndNavigate sequentially one after the other, which means the new report is not updated in Onyx yet. So, ReportUtils.getChatByParticipants returns nothing which then throws an error because we are trying to get its reportID.

What changes do you think we should make in order to solve the problem?

1. setAssigneeValue returns the reportID
2. Pass the reportID to editTaskAndNavigate as assigneeReportID in here
   

   App/src/pages/tasks/TaskAssigneeSelectorModal.js

   Lines 170 to 171 in 6183609

   	// Pass through the selected assignee
   	TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, props.session.accountID, {assignee: option.login, assigneeAccountID: option.accountID});

3. Replace ReportUtils.getChatByParticipant().reportID with assigneeReportID
   

   App/src/libs/actions/Task.js

   Lines 315 to 316 in 6183609

   	if (assigneeAccountID && assigneeAccountID !== report.managerID && assigneeAccountID !== ownerAccountID) {
   	assigneeChatReportID = ReportUtils.getChatByParticipants([assigneeAccountID]).reportID;

What alternative solutions did you explore? (Optional)

1. In setAssigneeValue, merge the reportID as assigneeReportID to ONYXKEYS.TASK
   

   App/src/libs/actions/Task.js

   Lines 500 to 501 in 6183609

   	// This is only needed for creation of a new task and so it should only be stored locally
   	Onyx.merge(ONYXKEYS.TASK, {assignee, assigneeAccountID: newAssigneeAccountID});

2. In TaskAssigneeSelectorModal, add a new ref isPendingEdit with an initial value of false.
3. Remove editTaskAndNavigate from here and replace it with isPendingEdit.current = true
   

   App/src/pages/tasks/TaskAssigneeSelectorModal.js

   Lines 170 to 171 in 6183609

   	// Pass through the selected assignee
   	TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, props.session.accountID, {assignee: option.login, assigneeAccountID: option.accountID});

4. In TaskAssigneeSelectorModal, add a new useEffect with props.task as the dependency array. If props.task changes and isPendingEdit is true, call editTaskAndNavigate and pass all assignee, assigneeAccountID, and assigneeReportID.

useEffect(() => {
    if (isPendingEdit.current) {
        TaskUtils.editTaskAndNavigate(props.task.report, props.session.email, props.session.accountID, {assignee: props.task.assignee, assigneeAccountID: props.task.assigneeAccountID, assigneeReportID: props.task.assigneeReportID})
    }
}, [props.task])

[CortneyOfstad]

I was also able to recreate this, so going to get eyes on this and the suggested proposal above 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cd84d993daec02b5

[melvin-bot]

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[fedirjh]

I would like to make a note that there is an ongoing refactor of the task detailed view under issue #20841. I believe it would be best to hold this issue until the refactor is completed.

[CortneyOfstad]

Thanks @fedirjh — going to change the frequency of this to Weekly 👍

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[thienlnam]

This is an internal issue - dupe of https://github.com/Expensify/Expensify/issues/294203

[alitoshmatov]

One more thing to consider
When we assign a user which we don't have previous chat with, it is creating optimistic data and adding it to personalDetailsList, this optimistic data has login and optimistically generated id, we also receiving actual data of user from backend. First time we are assigning this user in new task it is using optimistic ID of a user to find its report, the report data also is optimistic

App/src/libs/actions/Task.js

Line 43 in 1b958b8

const assigneeChatReportID = lodashGet(ReportUtils.getChatByParticipants([assigneeAccountID]), 'reportID');

But when we second time want to edit, the report data is updated, and has real ID of user participants field. But in selector we have optimistic id of a user and we cannot find its report and it results in new report creation.

We are having optimistic ID of a user because of this line, backend is not sending login field:

App/src/libs/actions/Task.js

Line 43 in 1b958b8

const assigneeChatReportID = lodashGet(ReportUtils.getChatByParticipants([assigneeAccountID]), 'reportID');

[melvin-bot]

@CortneyOfstad @abdulrahuman5196 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[CortneyOfstad]

WHY WHY WHY MUST MELVINBOT BE A PAIN.

Sorry for the unassigning and re-assign @kadiealexander 🤦 I'm going OoO until 8/14 so just need someone to keep an eye on this until I get back. Keeping myself assigned as well in the meantime. Thank you!

[kadiealexander]

Shifting to weekly while this is on hold.

[CortneyOfstad]

@kadiealexander I can take this back now that I have returned from being OoO — thanks for holding down the fort! 👍

[CortneyOfstad]

@thienlnam Where are we at with this? TIA for an updates!

[thienlnam]

The held issue should be on production today. After that, we can see if this is still reproducible and if not we can close!

[CortneyOfstad]

Thanks @thienlnam!!

[thienlnam]

Linked issue is resolved! Let's see if this is still reproducible

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

I'm not able to recreate this, so I think we're good to close! Thanks @thienlnam!