[HOLD #22699] Chat - Mention options are not updated dynamically for display name like we update reports

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open the app with another device and login with user B
3. In user A, open user B report and type in user B mention
4. From user B device, change the display name
5. Observe that app updates display name in report but does not update display name in mention options

Expected Result:

App should dynamically update display name in mention options as we do on reports page

Actual Result:

App does not dynamically update display name in mention options as we do on reports page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

dynamicallyupdate.display.name.in.mentions.1.mp4

Recording.3293.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687871873180969

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention suggestions are not updated dynamically

What is the root cause of that problem?

We don't re-calculate mentions when personalDetails change in ReportActionCompose.

This is the root cause

What changes do you think we should make in order to solve the problem?

In componentDidUpdate, add the following code

        if (prevProps.personalDetails !== this.props.personalDetails) {
            this.calculateMentionSuggestion();
        }

This works as expected.

Result

21816_mac_chrome.mp4

What alternative solutions did you explore? (Optional)

[CortneyOfstad]

@kbecciv These seems very similar to #21622. Do you feel like these can be merged together?

[CortneyOfstad]

Bump @kbecciv ^^

[CortneyOfstad]

Heading OoO for the week (back July 10) so re-assigning this in the meantime 👍

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

10 days overdue. I'm getting more depressed than Marvin.

[CortneyOfstad]

Not sure why this didn't get re-assigned when I reapplied the bug label 😑

[CortneyOfstad]

@kbecciv These seems very similar to #21622. Do you feel like these can be merged together?

[mallenexpensify]

Putting on hold pending

• [Tracking] Dynamically Updating issues #22699

Feel free to remove yourself @CortneyOfstad , since it might be a while til it's addressed.

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

On hold, bumped to Weekly

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@kbecciv, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.