False emergency label due to repeated checklist check

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Approve a PR with the reviewer checklist, see that all checks are passing.
2. Approve it again and immediately merge it.

Expected Result:

No Emergency label is added.

Actual Result:

The Emergency label is added.

Workaround:

Wait for the Reviewer Checklist job to finish running again before merging.

Platforms:

n/a – GitHub Actions

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01027ef414fe07c78d
• Upwork Job ID: 1676202679454892032
• Last Price Increase: 2023-07-04

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[roryabraham]

This is just annoying...

[roryabraham]

Example: #20257

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01027ef414fe07c78d

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[roryabraham]

I was surprised to see that there's already code here that should skip the emergency label if one or more checklist job passed.

So I think the reason this isn't working is because this line will only get the current check runs for the head ref of the PR. That's what we want for most checks, but for the checklist check in particular we want all historical check runs for the PR. Haven't confirmed yet, but I think we might want to list all check suites for the ref, then list all check runs for each check suites, and look for any passing checklist jobs.

[melvin-bot]

@eVoloshchak @roryabraham @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[roryabraham]

Going to close this one as low priority.