[HOLD on react-native-onyx#283] [$1000] Loading screen does not go away until a hard fresh when opening staging web

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com

Expected Result:

Chat should be loaded after a brief seconds

Actual Result:

Requires a hard refresh

NOTE: Bernhard Owen Josephus can reproduce in Dev

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688140800767229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ec38f8400cec889b
• Upwork Job ID: 1676993803918155776
• Last Price Increase: 2023-07-06

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

Not a lot to go off, I commented here in thread. A good place to start might be to figure out if there's something blocking the queue.

[trjExpensify]

Seems to be still happening to @AndrewGable and @bernhardoj, I'll move this on to external for more eyes. A possible lead is mentioned here in thread.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ec38f8400cec889b

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[waterim]

Cant reproduce

[trjExpensify]

Yeah, I think it's going to be a little tough. Did you check out the slack thread?

[Julesssss]

@waterim this likely won't be possible to reproduce, the cause is unknown at this point. But many of us have the issue so we should be able to verify any fix. I'll be looking into this today

[pasyukevich]

Hi,
I am from Callstack - an expert contributor group
I start to investigate this issue

[Julesssss]

Hey, thanks @pasyukevich but for now I'm going to loo into this myself.

[Christinadobrzyn]

Hey @sobitneupane We have this comment on another job- should we combine that job into this one? cc @aimane-chnaif

[Julesssss]

Based on the information that I got from the issue description and Slack thread to the issue, I assume that the root cause of the problem is the same - the Onyx library. I am more than sure that it can be fixed in the same way as I described here. (before it will be patched on the Onyx side)

Oh awesome, thanks. In that case please go ahead @pasyukevich, I'm assigned to the other issue and we can hold this one until a PR is reviewed.

[trjExpensify]

@Julesssss, the linked PR has closed. Confirming we're moving to this one? Expensify/react-native-onyx#283

[Julesssss]

@trjExpensify yep, we had to fix this in the Onyx repo, so that's the PR to keep an eye on.

[trjExpensify]

Cool, updated the title.

[trjExpensify]

Seems like that PR has stalled in review.

[trjExpensify]

Linked Onyx PR we're held on is still in review.

[JmillsExpensify]

What's the latest on this one. It's one of the variables we're trying to remove that is slowing down my account to a crawl.

[Julesssss]

Discussion occuring in the PR review

[Julesssss]

Just merged the Onyx PR and tested locally. Raised a PR for the Onyx lib bump here.

We never had reliable steps for reproducing this, so i think we'll need to merge with [NO QA] and ask people to test on staging.

[Julesssss]

We closed our PR as a newer one was opened that bumped the Onyx lib to a higher version.

What's the latest on this one. It's one of the variables we're trying to remove that is slowing down my account to a crawl.

But we should be ready to test the fix now!

[trjExpensify]

Okay, @bernhardoj do you want to give it a shot given you were impacted by this initially? @AndrewGable is out, I think.

[bernhardoj]

@trjExpensify I actually never experience this issue anymore for quite a few weeks, probably there are some other PRs that fix it?

[trjExpensify]

Perhaps! I never experienced it though, so I'm not sure. We could wait for a second opinion from @AndrewGable who was the other person experiencing it before we close it out officially.

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @trjExpensify, @pasyukevich, @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

I'm just going to go ahead and close this out. @AndrewGable if you do repro it, holla.